[01/11] Documentation: dt: Add #iommu-cells info to OMAP iommu bindings
diff mbox

Message ID 1437431613-55656-2-git-send-email-s-anna@ti.com
State New
Headers show

Commit Message

Suman Anna July 20, 2015, 10:33 p.m. UTC
The OMAP IOMMU bindings is updated to reflect the required #iommu-cells
property.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Laurent Pinchart July 21, 2015, 3:55 p.m. UTC | #1
Hi Suman,

Thank you for the patch.

On Monday 20 July 2015 17:33:23 Suman Anna wrote:
> The OMAP IOMMU bindings is updated to reflect the required #iommu-cells
> property.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>

This brings the documentation in sync with both mainline DT sources and code 
so it looks good to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
> b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt index
> 42531dc387aa..869699925fd5 100644
> --- a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
> +++ b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
> @@ -8,6 +8,11 @@ Required properties:
>  - ti,hwmods  : Name of the hwmod associated with the IOMMU instance
>  - reg        : Address space for the configuration registers
>  - interrupts : Interrupt specifier for the IOMMU instance
> +- #iommu-cells : Should be 0. OMAP IOMMUs are all "single-master" devices,
> +                 and needs no additional data in the pargs specifier.
> Please +                 also refer to the generic bindings document for
> more info +                 on this property,
> +                     Documentation/devicetree/bindings/iommu/iommu.txt
> 
>  Optional properties:
>  - ti,#tlb-entries : Number of entries in the translation look-aside buffer.
> @@ -18,6 +23,7 @@ Optional properties:
>  Example:
>  	/* OMAP3 ISP MMU */
>  	mmu_isp: mmu@480bd400 {
> +		#iommu-cells = <0>;
>  		compatible = "ti,omap2-iommu";
>  		reg = <0x480bd400 0x80>;
>  		interrupts = <24>;

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
index 42531dc387aa..869699925fd5 100644
--- a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
+++ b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
@@ -8,6 +8,11 @@  Required properties:
 - ti,hwmods  : Name of the hwmod associated with the IOMMU instance
 - reg        : Address space for the configuration registers
 - interrupts : Interrupt specifier for the IOMMU instance
+- #iommu-cells : Should be 0. OMAP IOMMUs are all "single-master" devices,
+                 and needs no additional data in the pargs specifier. Please
+                 also refer to the generic bindings document for more info
+                 on this property,
+                     Documentation/devicetree/bindings/iommu/iommu.txt
 
 Optional properties:
 - ti,#tlb-entries : Number of entries in the translation look-aside buffer.
@@ -18,6 +23,7 @@  Optional properties:
 Example:
 	/* OMAP3 ISP MMU */
 	mmu_isp: mmu@480bd400 {
+		#iommu-cells = <0>;
 		compatible = "ti,omap2-iommu";
 		reg = <0x480bd400 0x80>;
 		interrupts = <24>;