diff mbox

ALSA: hda - Add new GPU codec ID 0x10de007d to snd-hda

Message ID 1437437654-21375-1-git-send-email-aplattner@nvidia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Aaron Plattner July 21, 2015, 12:14 a.m. UTC 
Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
---
This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
here.

 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai July 21, 2015, 7:39 a.m. UTC | #1 
On Tue, 21 Jul 2015 02:14:14 +0200,
Aaron Plattner wrote:
> 
> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
> 
> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>

Applied, thanks.  But...

> ---
> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
> here.

Please include such important information into the changelog itself at
the next time.  I copied it manually.


Takashi

> 
>  sound/pci/hda/patch_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 95158914cc6c..a97db5fc8a15 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x10de0070, .name = "GPU 70 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de0072, .name = "GPU 72 HDMI/DP",	.patch = patch_nvhdmi },
> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP",	.patch = patch_nvhdmi },
>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
>  { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
>  MODULE_ALIAS("snd-hda-codec-id:10de0070");
>  MODULE_ALIAS("snd-hda-codec-id:10de0071");
>  MODULE_ALIAS("snd-hda-codec-id:10de0072");
> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
>  MODULE_ALIAS("snd-hda-codec-id:11069f81");
> -- 
> 2.4.6
> 
>
Aaron Plattner July 21, 2015, 7:47 a.m. UTC | #2 
On 07/21/2015 12:39 AM, Takashi Iwai wrote:
> On Tue, 21 Jul 2015 02:14:14 +0200,
> Aaron Plattner wrote:
>>
>> Vendor ID 0x10de007d is used by a yet-to-be-named GPU chip.
>>
>> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
> 
> Applied, thanks.  But...
> 
>> ---
>> This chip also has the 2-ch audio swapping bug, so patch_nvhdmi is appropriate
>> here.
> 
> Please include such important information into the changelog itself at
> the next time.  I copied it manually.

Oh, okay, sorry.  I figured that since the whole point of patch_nvhdmi
is the 2ch workaround, it should be obvious from context but it
certainly can't hurt to have it in the commit itself too.  Thanks for
taking care of it!

Sincerely,
Aaron

> Takashi
> 
>>
>>  sound/pci/hda/patch_hdmi.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
>> index 95158914cc6c..a97db5fc8a15 100644
>> --- a/sound/pci/hda/patch_hdmi.c
>> +++ b/sound/pci/hda/patch_hdmi.c
>> @@ -3512,6 +3512,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>>  { .id = 0x10de0070, .name = "GPU 70 HDMI/DP",	.patch = patch_nvhdmi },
>>  { .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
>>  { .id = 0x10de0072, .name = "GPU 72 HDMI/DP",	.patch = patch_nvhdmi },
>> +{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP",	.patch = patch_nvhdmi },
>>  { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
>>  { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
>>  { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
>> @@ -3576,6 +3577,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0067");
>>  MODULE_ALIAS("snd-hda-codec-id:10de0070");
>>  MODULE_ALIAS("snd-hda-codec-id:10de0071");
>>  MODULE_ALIAS("snd-hda-codec-id:10de0072");
>> +MODULE_ALIAS("snd-hda-codec-id:10de007d");
>>  MODULE_ALIAS("snd-hda-codec-id:10de8001");
>>  MODULE_ALIAS("snd-hda-codec-id:11069f80");
>>  MODULE_ALIAS("snd-hda-codec-id:11069f81");
>> -- 
>> 2.4.6
>>
diff mbox

Patch

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 95158914cc6c..a97db5fc8a15 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3512,6 +3512,7 @@  static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x10de0070, .name = "GPU 70 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0071, .name = "GPU 71 HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de0072, .name = "GPU 72 HDMI/DP",	.patch = patch_nvhdmi },
+{ .id = 0x10de007d, .name = "GPU 7d HDMI/DP",	.patch = patch_nvhdmi },
 { .id = 0x10de8001, .name = "MCP73 HDMI",	.patch = patch_nvhdmi_2ch },
 { .id = 0x11069f80, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
 { .id = 0x11069f81, .name = "VX900 HDMI/DP",	.patch = patch_via_hdmi },
@@ -3576,6 +3577,7 @@  MODULE_ALIAS("snd-hda-codec-id:10de0067");
 MODULE_ALIAS("snd-hda-codec-id:10de0070");
 MODULE_ALIAS("snd-hda-codec-id:10de0071");
 MODULE_ALIAS("snd-hda-codec-id:10de0072");
+MODULE_ALIAS("snd-hda-codec-id:10de007d");
 MODULE_ALIAS("snd-hda-codec-id:10de8001");
 MODULE_ALIAS("snd-hda-codec-id:11069f80");
 MODULE_ALIAS("snd-hda-codec-id:11069f81");