| Message ID | 1437467876-22106-12-git-send-email-yangds.fnst@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 21.07.2015 um 10:37 schrieb Dongsheng Yang: > We want to use read_block to read quota file bypass the page cache. > So export it from file.c, then we can use it in somewhere else. > > Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> > --- > fs/ubifs/file.c | 2 +- > fs/ubifs/ubifs.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index 27de484..dc8bf0b 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -54,7 +54,7 @@ > #include <linux/namei.h> > #include <linux/slab.h> > > -static int read_block(struct inode *inode, void *addr, unsigned int block, > +int read_block(struct inode *inode, void *addr, unsigned int block, > struct ubifs_data_node *dn) > { > struct ubifs_info *c = inode->i_sb->s_fs_info; > diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h > index ae6723e..a6ad955 100644 > --- a/fs/ubifs/ubifs.h > +++ b/fs/ubifs/ubifs.h > @@ -1749,6 +1749,8 @@ const struct ubifs_lprops *ubifs_fast_find_frdi_idx(struct ubifs_info *c); > int ubifs_calc_dark(const struct ubifs_info *c, int spc); > > /* file.c */ > +int read_block(struct inode *inode, void *addr, unsigned int block, > + struct ubifs_data_node *dn); Please prefix the function name with ubifs_ to avoid namespace pollution. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/22/2015 04:36 AM, Richard Weinberger wrote: > Am 21.07.2015 um 10:37 schrieb Dongsheng Yang: >> We want to use read_block to read quota file bypass the page cache. >> So export it from file.c, then we can use it in somewhere else. >> >> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> >> --- >> fs/ubifs/file.c | 2 +- >> fs/ubifs/ubifs.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c >> index 27de484..dc8bf0b 100644 >> --- a/fs/ubifs/file.c >> +++ b/fs/ubifs/file.c >> @@ -54,7 +54,7 @@ >> #include <linux/namei.h> >> #include <linux/slab.h> >> >> -static int read_block(struct inode *inode, void *addr, unsigned int block, >> +int read_block(struct inode *inode, void *addr, unsigned int block, >> struct ubifs_data_node *dn) >> { >> struct ubifs_info *c = inode->i_sb->s_fs_info; >> diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h >> index ae6723e..a6ad955 100644 >> --- a/fs/ubifs/ubifs.h >> +++ b/fs/ubifs/ubifs.h >> @@ -1749,6 +1749,8 @@ const struct ubifs_lprops *ubifs_fast_find_frdi_idx(struct ubifs_info *c); >> int ubifs_calc_dark(const struct ubifs_info *c, int spc); >> >> /* file.c */ >> +int read_block(struct inode *inode, void *addr, unsigned int block, >> + struct ubifs_data_node *dn); > > Please prefix the function name with ubifs_ to avoid namespace pollution. Good point, thanx > > Thanks, > //richard > . > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 27de484..dc8bf0b 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -54,7 +54,7 @@ #include <linux/namei.h> #include <linux/slab.h> -static int read_block(struct inode *inode, void *addr, unsigned int block, +int read_block(struct inode *inode, void *addr, unsigned int block, struct ubifs_data_node *dn) { struct ubifs_info *c = inode->i_sb->s_fs_info; diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h index ae6723e..a6ad955 100644 --- a/fs/ubifs/ubifs.h +++ b/fs/ubifs/ubifs.h @@ -1749,6 +1749,8 @@ const struct ubifs_lprops *ubifs_fast_find_frdi_idx(struct ubifs_info *c); int ubifs_calc_dark(const struct ubifs_info *c, int spc); /* file.c */ +int read_block(struct inode *inode, void *addr, unsigned int block, + struct ubifs_data_node *dn); int ubifs_fsync(struct file *file, loff_t start, loff_t end, int datasync); int ubifs_setattr(struct dentry *dentry, struct iattr *attr);
We want to use read_block to read quota file bypass the page cache. So export it from file.c, then we can use it in somewhere else. Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> --- fs/ubifs/file.c | 2 +- fs/ubifs/ubifs.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)