Firefly wifi mainline patches
diff mbox

Message ID CAOf5uw=cvu9ST+QexgMQP06xQVAz6th_EepfxQOAXNDrWopf6Q@mail.gmail.com
State New
Headers show

Commit Message

Michael Nazzareno Trimarchi July 22, 2015, 5:58 a.m. UTC
Hi


On Tue, Jul 21, 2015 at 2:51 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:
> Hi
>
> I have managed to let my wifi working using mainline but I have
> problem on clocking. Right now I can not rise the clock more the 5Mhz
> even it's suppose to work up to 50Mhz. Anyone is working on it right
> now?
>

I put in attach two patches that I need on my version. Another problem
is that execute_tuning is not defined in the dw_mmc-rockchip so
ENOSYS is returned. I think that we have two way:

1) put a stub
2) define 0 as default error

Michael

> Michael

Comments

Romain Perier July 22, 2015, 6:45 a.m. UTC | #1
Hi Michael,

You can ask and discuss about wifi here, but could you re-send you
patches as described in [1] please ?

Short version:
1. git format-patch HEAD~2  # extract your two commits
2. scripts/get_maintainer.pl -f  <changed_files> # list maintainers
3. git send-email --to --cc  <emails  listed by get_maintainer.pl>   *.patch

Thanks in advance,
Have a nice day,
Romain

1. https://www.kernel.org/doc/Documentation/SubmittingPatches


2015-07-22 7:58 GMT+02:00 Michael Trimarchi <michael@amarulasolutions.com>:
> Hi
>
>
> On Tue, Jul 21, 2015 at 2:51 PM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
>> Hi
>>
>> I have managed to let my wifi working using mainline but I have
>> problem on clocking. Right now I can not rise the clock more the 5Mhz
>> even it's suppose to work up to 50Mhz. Anyone is working on it right
>> now?
>>
>
> I put in attach two patches that I need on my version. Another problem
> is that execute_tuning is not defined in the dw_mmc-rockchip so
> ENOSYS is returned. I think that we have two way:
>
> 1) put a stub
> 2) define 0 as default error
>
> Michael
>
>> Michael
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
Doug Anderson July 22, 2015, 1:36 p.m. UTC | #2
Hi,

On Tue, Jul 21, 2015 at 10:58 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:
> Hi
>
>
> On Tue, Jul 21, 2015 at 2:51 PM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
>> Hi
>>
>> I have managed to let my wifi working using mainline but I have
>> problem on clocking. Right now I can not rise the clock more the 5Mhz
>> even it's suppose to work up to 50Mhz. Anyone is working on it right
>> now?
>>
>
> I put in attach two patches that I need on my version. Another problem
> is that execute_tuning is not defined in the dw_mmc-rockchip so
> ENOSYS is returned. I think that we have two way:
>
> 1) put a stub
> 2) define 0 as default error

I don't think you should be trying to tune until the tuning patches
are landed.  Alexandru sent them up a while ago but they need to be
respun.  I seem to remember Alexandru saying that it decided your
controller was UHS capable if you didn't specify any capabilities, so
maybe that's it.

Try adding this to your SDIO port in the dts:

cap-sd-highspeed;

Patch
diff mbox

From 4d68f996e28aa135a331e67ccd95874632276606 Mon Sep 17 00:00:00 2001
From: Michael Trimarchi <michael@amarulasolutions.com>
Date: Tue, 21 Jul 2015 15:21:48 +0200
Subject: [PATCH] firefly: add a minimal wifi settings

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 arch/arm/boot/dts/rk3288-firefly.dtsi | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
index 149b9ed..effce71 100644
--- a/arch/arm/boot/dts/rk3288-firefly.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
@@ -116,6 +116,19 @@ 
 		vin-supply = <&vcc_io>;
 	};
 
+	vcc_wifi: wifi-regulator {
+		compatible = "regulator-fixed";
+		gpio = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&sdio0_pwr>;
+		regulator-name = "vcc_wifi";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		startup-delay-us = <100000>;
+		vin-supply = <&vcc_io>;
+	};
+
+
 	vcc_flash: flash-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_flash";
@@ -460,13 +473,31 @@ 
 &sdio0 {
 	broken-cd;
 	bus-width = <4>;
+	clock-freq-min-max = <400000 5000000>;
 	disable-wp;
 	non-removable;
+	cap-sd--highspeed;
 	num-slots = <1>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&sdio0_bus4>, <&sdio0_cmd>, <&sdio0_clk>;
+	pinctrl-0 = <&sdio0_bus4>, <&sdio0_cmd>, <&sdio0_clk>, <&sdio0_int>;
+
+	sd-uhs-sdr104;
+	sd-uhs-sdr12;
+	sd-uhs-sdr25;
+	cap-sdio-irq;
+
 	vmmc-supply = <&vcc_18>;
+/*	mmc-supply = <&vcc_wifi>; */
 	status = "okay";
+
+	brcmf: bcrmf@1 {
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&gpio4>;
+		reg = <0>;
+		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-names = "host-wake";
+		status = "okay";
+	};
 };
 
 &sdmmc {
-- 
1.9.1