From patchwork Wed Jul 22 14:30:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6844801 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2C4CCC05AD for ; Wed, 22 Jul 2015 14:27:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D174206E8 for ; Wed, 22 Jul 2015 14:27:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id EC370206E4 for ; Wed, 22 Jul 2015 14:27:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C66107A161; Wed, 22 Jul 2015 07:27:50 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5EF17A162 for ; Wed, 22 Jul 2015 07:27:48 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so166151934wib.0 for ; Wed, 22 Jul 2015 07:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Geqx+6JRI4WiiiJfl69ZtMvkJvoeARdmLbrqwRLfrUQ=; b=BPOKZFC4TRu21FacUYjUDvJ//2ffkkfXdXsZXNyyVbV7wXEM3SoPkJkfY4niIK55TV 5ThCu096X+CIpi2MZxqGweWls3HQV8d85tuxf7CZryKadyjS3MiFeZwcxu+m5LfnGoAp 8J/eiLk25KhDpzqffzWtRgIPCZueMW5pSbBzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Geqx+6JRI4WiiiJfl69ZtMvkJvoeARdmLbrqwRLfrUQ=; b=NSIp8vt7Z24H52Vc+zSuEyS+6RgditHVw60z0ypAWBiQRZTaewBY7pWPCNia1HXh6M vo2N+rA+JTTh1xLVNqIn+BX2W8oKqnW8F2pZTdwx+E4YUGWZsuYtrHh3jsAJoTjf+W2X LfKobEorHbuMEvD7IqXt+Cd/z8ATwL5EWS/wcucH4kS2rDsEixYrTd9/DMePMpdMBJH4 6rqjwIHYmJBgBh3amNSv0KTAOA+ymeUeaXpnGeTB+Tcx/c+EP6eGd8heRDpr5zCXqD+C ZAElzPkW3U5kxd7nSpv3Xj8U3bS33T3FXRgJqgHtSJObw5nqVTxmYeZ+xADz67a1tZaR hRyg== X-Gm-Message-State: ALoCoQlrmIy2vNhfyjxtXHcKyBzsKY9FZunRr9hNIs1QzZ73qiGAeWYfrbiE5VbAHjm4h1G/A9kG X-Received: by 10.180.73.244 with SMTP id o20mr7089341wiv.31.1437575267411; Wed, 22 Jul 2015 07:27:47 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id r6sm22326075wiy.13.2015.07.22.07.27.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Jul 2015 07:27:46 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/2] drm/rcar: Only update planes on active crtc Date: Wed, 22 Jul 2015 16:30:21 +0200 Message-Id: <1437575421-26026-2-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437575421-26026-1-git-send-email-daniel.vetter@ffwll.ch> References: <1437575421-26026-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Laurent Pinchart , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP R-car does runtime pm (that's why it's committing plane state only at the end). Therefore better to only update planes on active crtc. Note that since the helpers always add all enabled planes when doing a modeset change on a crtc we are guaranteed to update plane hw state to the latest requested state each time the crtc is enabled. Cc: Laurent Pinchart Signed-off-by: Daniel Vetter --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ca12e8ca5552..20813582fbf1 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c @@ -456,7 +456,7 @@ static void rcar_du_atomic_complete(struct rcar_du_commit *commit) /* Apply the atomic update. */ drm_atomic_helper_commit_modeset_disables(dev, old_state); drm_atomic_helper_commit_modeset_enables(dev, old_state); - drm_atomic_helper_commit_planes(dev, old_state, false); + drm_atomic_helper_commit_planes(dev, old_state, true); drm_atomic_helper_wait_for_vblanks(dev, old_state);