[v2] ALSA: hda - Fix the headset mic that will not work on Dell desktop machine
diff mbox

Message ID 1437733368-6690-1-git-send-email-woodrow.shen@canonical.com
State New
Headers show

Commit Message

woodrow.shen@canonical.com July 24, 2015, 10:22 a.m. UTC
When the headset was plugged in the Dell desktop, the mic of headset can't be detected and workable.
According to the alsa-info, we found the differece between alsa and init_pin_configs
on the machine, so we need to add the pin configs to make headset work.

Codec: Realtek ALC3234
Vendor Id: 0x10ec0255
Subsystem Id: 0x102806bb

BugLink: https://bugs.launchpad.net/bugs/1477900
Signed-off-by: Woodrow Shen <woodrow.shen@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Takashi Iwai July 24, 2015, 4:26 p.m. UTC | #1
On Fri, 24 Jul 2015 12:22:48 +0200,
woodrow.shen@canonical.com wrote:
> 
> When the headset was plugged in the Dell desktop, the mic of headset can't be detected and workable.
> According to the alsa-info, we found the differece between alsa and init_pin_configs
> on the machine, so we need to add the pin configs to make headset work.
> 
> Codec: Realtek ALC3234
> Vendor Id: 0x10ec0255
> Subsystem Id: 0x102806bb
> 
> BugLink: https://bugs.launchpad.net/bugs/1477900
> Signed-off-by: Woodrow Shen <woodrow.shen@canonical.com>

Your MUA doesn't give your name in "From:" line.  Please either fix
MUA setup or add From: line directly in the patch, at best to match
with your sign-off.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 742fc62..d94c0e3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5473,6 +5473,28 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x1e, 0x411111f0},
>  		{0x21, 0x0221103f}),
>  	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0x40000000},
> +		{0x14, 0x90170150},
> +		{0x17, 0x411111f0},
> +		{0x18, 0x411111f0},
> +		{0x19, 0x411111f0},
> +		{0x1a, 0x411111f0},
> +		{0x1b, 0x02011020},
> +		{0x1d, 0x4054c029},
> +		{0x1e, 0x411111f0},
> +		{0x21, 0x0221105f}),
> +	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0x40000000},
> +		{0x14, 0x90170110},
> +		{0x17, 0x411111f0},
> +		{0x18, 0x411111f0},
> +		{0x19, 0x411111f0},
> +		{0x1a, 0x411111f0},
> +		{0x1b, 0x01014020},
> +		{0x1d, 0x4054c029},
> +		{0x1e, 0x411111f0},
> +		{0x21, 0x0221101f}),
> +	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>  		{0x12, 0x90a60160},
>  		{0x14, 0x90170120},
>  		{0x17, 0x90170140},
> -- 
> 2.1.4
>

Patch
diff mbox

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 742fc62..d94c0e3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5473,6 +5473,28 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x1e, 0x411111f0},
 		{0x21, 0x0221103f}),
 	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x12, 0x40000000},
+		{0x14, 0x90170150},
+		{0x17, 0x411111f0},
+		{0x18, 0x411111f0},
+		{0x19, 0x411111f0},
+		{0x1a, 0x411111f0},
+		{0x1b, 0x02011020},
+		{0x1d, 0x4054c029},
+		{0x1e, 0x411111f0},
+		{0x21, 0x0221105f}),
+	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x12, 0x40000000},
+		{0x14, 0x90170110},
+		{0x17, 0x411111f0},
+		{0x18, 0x411111f0},
+		{0x19, 0x411111f0},
+		{0x1a, 0x411111f0},
+		{0x1b, 0x01014020},
+		{0x1d, 0x4054c029},
+		{0x1e, 0x411111f0},
+		{0x21, 0x0221101f}),
+	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
 		{0x12, 0x90a60160},
 		{0x14, 0x90170120},
 		{0x17, 0x90170140},