[1/2] drm: Add DRM_ERROR_ON replacement for WARN_ON
diff mbox

Message ID 1437988648-3829-1-git-send-email-chris@chris-wilson.co.uk
State New
Headers show

Commit Message

Chris Wilson July 27, 2015, 9:17 a.m. UTC
i915 has a habit of using WARN_ON and spewing stacktraces into the
kernel logs and beyond. For the majority of cases, we do not care about
the stacktrace, we know precisely where and when the error occurs so
hunting down the exact instance is not a concern, we only need the
content of the error.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 include/drm/drmP.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Patch
diff mbox

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 4717449d6aa9..b76af322d812 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -164,6 +164,23 @@  void drm_err(const char *format, ...);
 	drm_err(fmt, ##__VA_ARGS__)
 
 /**
+ * Assertion-esque error output.
+ *
+ * \param cond condition on which to *fail*
+ * \param fmt printf() like format string.
+ * \param arg arguments
+ *
+ * This is similar to WARN_ON but only prints a DRM_ERROR rather than a whole
+ * stacktrace.
+ */
+#define DRM_ERROR_ON(cond, fmt, ...) ({					\
+	bool __cond = !!(cond);						\
+	if (unlikely(__cond))						\
+		drm_err("assertion failed, %s: " fmt, #cond, ##__VA_ARGS__); \
+	unlikely(__cond);						\
+})
+
+/**
  * Rate limited error output.  Like DRM_ERROR() but won't flood the log.
  *
  * \param fmt printf() like format string.