[v2,3/3] ARM: dts: dra7: Add scm_conf@1c04 node
diff mbox

Message ID 1437992850-6008-4-git-send-email-rogerq@ti.com
State New
Headers show

Commit Message

Roger Quadros July 27, 2015, 10:27 a.m. UTC
This region contains CTRL_CORE_SMA_SW2..9 registers which
are not specific to any domain and can be reasonably
accessed via syscon driver.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/dra7.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kishon Vijay Abraham I Aug. 3, 2015, 3:51 p.m. UTC | #1
Hi Roger,

On Monday 27 July 2015 03:57 PM, Roger Quadros wrote:
> This region contains CTRL_CORE_SMA_SW2..9 registers which
> are not specific to any domain and can be reasonably
> accessed via syscon driver.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 913032b..43b5074 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -149,6 +149,13 @@
>  					pinctrl-single,register-width = <32>;
>  					pinctrl-single,function-mask = <0x3fffffff>;
>  				};
> +
> +				scm_conf1: scm_conf@1c04 {
> +					compatible = "syscon";
> +					reg = <0x1c04 0x0020>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;

Why do you need address-cells and size-cells property here? AFAIK it is usually
used to decode childs reg property.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roger Quadros Aug. 4, 2015, 8:10 a.m. UTC | #2
On 03/08/15 18:51, Kishon Vijay Abraham I wrote:
> Hi Roger,
> 
> On Monday 27 July 2015 03:57 PM, Roger Quadros wrote:
>> This region contains CTRL_CORE_SMA_SW2..9 registers which
>> are not specific to any domain and can be reasonably
>> accessed via syscon driver.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  arch/arm/boot/dts/dra7.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 913032b..43b5074 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -149,6 +149,13 @@
>>  					pinctrl-single,register-width = <32>;
>>  					pinctrl-single,function-mask = <0x3fffffff>;
>>  				};
>> +
>> +				scm_conf1: scm_conf@1c04 {
>> +					compatible = "syscon";
>> +					reg = <0x1c04 0x0020>;
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
> 
> Why do you need address-cells and size-cells property here? AFAIK it is usually
> used to decode childs reg property.

Right. I'll remove them.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 913032b..43b5074 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -149,6 +149,13 @@ 
 					pinctrl-single,register-width = <32>;
 					pinctrl-single,function-mask = <0x3fffffff>;
 				};
+
+				scm_conf1: scm_conf@1c04 {
+					compatible = "syscon";
+					reg = <0x1c04 0x0020>;
+					#address-cells = <1>;
+					#size-cells = <1>;
+				};
 			};
 
 			cm_core_aon: cm_core_aon@5000 {