[v2,2/2] ARM: dts: am57xx-beagle-x15: use palmas-usb for USB2
diff mbox

Message ID 1438002617-15152-3-git-send-email-rogerq@ti.com
State New
Headers show

Commit Message

Roger Quadros July 27, 2015, 1:10 p.m. UTC
The VBUS line of USB2 is connected to VBUS detect logic on
the PMIC. Use the palmas-usb driver to report VBUS events
to the USB driver.

As the palmas-usb driver supports GPIO based ID reporting
provide the GPIO for ID pin as well.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

Comments

Tony Lindgren Aug. 5, 2015, 10:37 a.m. UTC | #1
* Roger Quadros <rogerq@ti.com> [150727 06:13]:
> The VBUS line of USB2 is connected to VBUS detect logic on
> the PMIC. Use the palmas-usb driver to report VBUS events
> to the USB driver.
> 
> As the palmas-usb driver supports GPIO based ID reporting
> provide the GPIO for ID pin as well.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

This should not cause merge conflicts with what I have queeud
for v4.3, so Chanwoo please feel free to apply with the rest
of the extcon series:

Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chanwoo Choi Aug. 5, 2015, 11:36 p.m. UTC | #2
On 08/05/2015 07:37 PM, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [150727 06:13]:
>> The VBUS line of USB2 is connected to VBUS detect logic on
>> the PMIC. Use the palmas-usb driver to report VBUS events
>> to the USB driver.
>>
>> As the palmas-usb driver supports GPIO based ID reporting
>> provide the GPIO for ID pin as well.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> This should not cause merge conflicts with what I have queeud
> for v4.3, so Chanwoo please feel free to apply with the rest
> of the extcon series:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
> 

I reviewd this patchset related to extcon and give the acked-by message.
but patch1 must need the acked-by message from MFD maintainer.

If patch1 receive the acked-by message from MFD maintainer,
I'll apply it for v4.3.

Roger,
I think that you better to recevie the acked-by message before v4.2-rc6 release.
I have the plan about pull request of extcon for v4.3 after v4.2-rc6 releas.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roger Quadros Sept. 3, 2015, 7:36 a.m. UTC | #3
Chanwoo,

On 06/08/15 02:36, Chanwoo Choi wrote:
> On 08/05/2015 07:37 PM, Tony Lindgren wrote:
>> * Roger Quadros <rogerq@ti.com> [150727 06:13]:
>>> The VBUS line of USB2 is connected to VBUS detect logic on
>>> the PMIC. Use the palmas-usb driver to report VBUS events
>>> to the USB driver.
>>>
>>> As the palmas-usb driver supports GPIO based ID reporting
>>> provide the GPIO for ID pin as well.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>
>> This should not cause merge conflicts with what I have queeud
>> for v4.3, so Chanwoo please feel free to apply with the rest
>> of the extcon series:
>>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>>
> 
> I reviewd this patchset related to extcon and give the acked-by message.
> but patch1 must need the acked-by message from MFD maintainer.
> 
> If patch1 receive the acked-by message from MFD maintainer,
> I'll apply it for v4.3.
> 
> Roger,
> I think that you better to recevie the acked-by message before v4.2-rc6 release.
> I have the plan about pull request of extcon for v4.3 after v4.2-rc6 releas.

Seems like you picked patch 1 but not this one. As Tony has already Acked it
can you please include patch 2 as well in your tree for -next? Thanks.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roger Quadros Sept. 15, 2015, 10:43 a.m. UTC | #4
Tony,

On 03/09/15 10:36, Roger Quadros wrote:
> Chanwoo,
> 
> On 06/08/15 02:36, Chanwoo Choi wrote:
>> On 08/05/2015 07:37 PM, Tony Lindgren wrote:
>>> * Roger Quadros <rogerq@ti.com> [150727 06:13]:
>>>> The VBUS line of USB2 is connected to VBUS detect logic on
>>>> the PMIC. Use the palmas-usb driver to report VBUS events
>>>> to the USB driver.
>>>>
>>>> As the palmas-usb driver supports GPIO based ID reporting
>>>> provide the GPIO for ID pin as well.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>>
>>> This should not cause merge conflicts with what I have queeud
>>> for v4.3, so Chanwoo please feel free to apply with the rest
>>> of the extcon series:
>>>
>>> Acked-by: Tony Lindgren <tony@atomide.com>
>>>
>>,
>> I reviewd this patchset related to extcon and give the acked-by message.
>> but patch1 must need the acked-by message from MFD maintainer.
>>
>> If patch1 receive the acked-by message from MFD maintainer,
>> I'll apply it for v4.3.
>>
>> Roger,
>> I think that you better to recevie the acked-by message before v4.2-rc6 release.
>> I have the plan about pull request of extcon for v4.3 after v4.2-rc6 releas.
> 
> Seems like you picked patch 1 but not this one. As Tony has already Acked it
> can you please include patch 2 as well in your tree for -next? Thanks.
> 

Is it possible for you to pick this up for -rc cycle via omap-soc tree?
Thanks.

--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Sept. 17, 2015, 12:06 a.m. UTC | #5
* Roger Quadros <rogerq@ti.com> [150915 03:46]:
> Tony,
> 
> On 03/09/15 10:36, Roger Quadros wrote:
> > Chanwoo,
> > 
> > On 06/08/15 02:36, Chanwoo Choi wrote:
> >> On 08/05/2015 07:37 PM, Tony Lindgren wrote:
> >>> * Roger Quadros <rogerq@ti.com> [150727 06:13]:
> >>>> The VBUS line of USB2 is connected to VBUS detect logic on
> >>>> the PMIC. Use the palmas-usb driver to report VBUS events
> >>>> to the USB driver.
> >>>>
> >>>> As the palmas-usb driver supports GPIO based ID reporting
> >>>> provide the GPIO for ID pin as well.
> >>>>
> >>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >>>
> >>> This should not cause merge conflicts with what I have queeud
> >>> for v4.3, so Chanwoo please feel free to apply with the rest
> >>> of the extcon series:
> >>>
> >>> Acked-by: Tony Lindgren <tony@atomide.com>
> >>>
> >>,
> >> I reviewd this patchset related to extcon and give the acked-by message.
> >> but patch1 must need the acked-by message from MFD maintainer.
> >>
> >> If patch1 receive the acked-by message from MFD maintainer,
> >> I'll apply it for v4.3.
> >>
> >> Roger,
> >> I think that you better to recevie the acked-by message before v4.2-rc6 release.
> >> I have the plan about pull request of extcon for v4.3 after v4.2-rc6 releas.
> > 
> > Seems like you picked patch 1 but not this one. As Tony has already Acked it
> > can you please include patch 2 as well in your tree for -next? Thanks.
> > 
> 
> Is it possible for you to pick this up for -rc cycle via omap-soc tree?
> Thanks.

OK picking up the second patch into omap-for-v4.3/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index a63bf78..f32cf20 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -98,13 +98,6 @@ 
 		pinctrl-0 = <&extcon_usb1_pins>;
 	};
 
-	extcon_usb2: extcon_usb2 {
-		compatible = "linux,extcon-usb-gpio";
-		id-gpio = <&gpio7 24 GPIO_ACTIVE_HIGH>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&extcon_usb2_pins>;
-	};
-
 	hdmi0: connector {
 		compatible = "hdmi-connector";
 		label = "hdmi";
@@ -326,12 +319,6 @@ 
 		>;
 	};
 
-	extcon_usb2_pins: extcon_usb2_pins {
-		pinctrl-single,pins = <
-			0x3e8 (PIN_INPUT_PULLUP | MUX_MODE14) /* uart1_ctsn.gpio7_24 */
-		>;
-	};
-
 	tpd12s015_pins: pinmux_tpd12s015_pins {
 		pinctrl-single,pins = <
 			0x3b0 (PIN_OUTPUT | MUX_MODE14)		/* gpio7_10 CT_CP_HPD */
@@ -495,6 +482,14 @@ 
 			gpio-controller;
 			#gpio-cells = <2>;
 		};
+
+		extcon_usb2: tps659038_usb {
+			compatible = "ti,palmas-usb-vid";
+			ti,enable-vbus-detection;
+			ti,enable-id-detection;
+			id-gpios = <&gpio7 24 GPIO_ACTIVE_HIGH>;
+		};
+
 	};
 
 	tmp102: tmp102@48 {
@@ -624,6 +619,14 @@ 
 };
 
 &usb2 {
+	/*
+	 * Stand alone usage is peripheral only.
+	 * However, with some resistor modifications
+	 * this port can be used via expansion connectors
+	 * as "host" or "dual-role". If so, provide
+	 * the necessary dr_mode override in the expansion
+	 * board's DT.
+	 */
 	dr_mode = "peripheral";
 };