| Message ID | 1438006967-18815-3-git-send-email-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 27, 2015 at 10:22:45AM -0400, Theodore Ts'o wrote: > SIGCLD is the name used by System V; SIGCHLD is the name defined by > Posix. Some C libraries will only define SIGCHLD and not SIGCLD, so > accomodate them. Please just use SIGCHLD unconditionally, there is no point in supporting pre-Posix systems in xfstests. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 30, 2015 at 10:14:28AM -0700, Christoph Hellwig wrote: > On Mon, Jul 27, 2015 at 10:22:45AM -0400, Theodore Ts'o wrote: > > SIGCLD is the name used by System V; SIGCHLD is the name defined by > > Posix. Some C libraries will only define SIGCHLD and not SIGCLD, so > > accomodate them. > > Please just use SIGCHLD unconditionally, there is no point in supporting > pre-Posix systems in xfstests. Ack, will do. - Ted -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ltp/doio.c b/ltp/doio.c index 966cff1..3e525d4 100644 --- a/ltp/doio.c +++ b/ltp/doio.c @@ -361,7 +361,11 @@ char **argv; case SIGTSTP: case SIGSTOP: case SIGCONT: +#if defined(SIGCLD) case SIGCLD: +#elif defined (SIGCHLD) + case SIGCHLD: +#endif case SIGBUS: case SIGSEGV: case SIGQUIT: diff --git a/ltp/growfiles.c b/ltp/growfiles.c index 06f179f..19ed013 100644 --- a/ltp/growfiles.c +++ b/ltp/growfiles.c @@ -1389,7 +1389,11 @@ set_sig() #ifdef SIGRESTART case SIGRESTART: #endif /* SIGRESTART */ - case SIGCLD: +#if defined(SIGCLD) + case SIGCLD: +#elif defined(SIGCHLD) + case SIGCHLD: +#endif break; default:
SIGCLD is the name used by System V; SIGCHLD is the name defined by Posix. Some C libraries will only define SIGCHLD and not SIGCLD, so accomodate them. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- ltp/doio.c | 4 ++++ ltp/growfiles.c | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-)