[media] imageon-bridge: Add module license information
diff mbox

Message ID 1438061985-2786-1-git-send-email-mike.looijmans@topic.nl
State New
Headers show

Commit Message

Mike Looijmans July 28, 2015, 5:39 a.m. UTC
Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
This fixes the driver failing to load when built as module:
  imageon_bridge: module license 'unspecified' taints kernel.
  imageon_bridge: Unknown symbol ...
As an extra service, also add a description.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/media/platform/imageon-bridge.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Hans Verkuil July 28, 2015, 7:14 a.m. UTC | #1
On 07/28/2015 07:39 AM, Mike Looijmans wrote:
> Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
> This fixes the driver failing to load when built as module:
>   imageon_bridge: module license 'unspecified' taints kernel.
>   imageon_bridge: Unknown symbol ...
> As an extra service, also add a description.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  drivers/media/platform/imageon-bridge.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
> index 9550695..a69b6da 100644
> --- a/drivers/media/platform/imageon-bridge.c
> +++ b/drivers/media/platform/imageon-bridge.c
> @@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
>  	.remove = imageon_bridge_remove,
>  };
>  module_platform_driver(imageon_bridge_driver);
> +
> +MODULE_DESCRIPTION("Imageon video bridge");
> +MODULE_LICENSE("GPL v2");
> 

Lovely, but unfortunately the imageon driver is not part of the official linux kernel.

So we can't do anything with this patch.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lars-Peter Clausen July 28, 2015, 7:47 a.m. UTC | #2
On 07/28/2015 09:14 AM, Hans Verkuil wrote:
> On 07/28/2015 07:39 AM, Mike Looijmans wrote:
>> Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
>> This fixes the driver failing to load when built as module:
>>    imageon_bridge: module license 'unspecified' taints kernel.
>>    imageon_bridge: Unknown symbol ...
>> As an extra service, also add a description.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   drivers/media/platform/imageon-bridge.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
>> index 9550695..a69b6da 100644
>> --- a/drivers/media/platform/imageon-bridge.c
>> +++ b/drivers/media/platform/imageon-bridge.c
>> @@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
>>   	.remove = imageon_bridge_remove,
>>   };
>>   module_platform_driver(imageon_bridge_driver);
>> +
>> +MODULE_DESCRIPTION("Imageon video bridge");
>> +MODULE_LICENSE("GPL v2");
>>
>
> Lovely, but unfortunately the imageon driver is not part of the official linux kernel.
>
> So we can't do anything with this patch.

I've applied the patch, thanks. Hopefully the driver will find its way 
upstream soon.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
index 9550695..a69b6da 100644
--- a/drivers/media/platform/imageon-bridge.c
+++ b/drivers/media/platform/imageon-bridge.c
@@ -317,3 +317,6 @@  static struct platform_driver imageon_bridge_driver = {
 	.remove = imageon_bridge_remove,
 };
 module_platform_driver(imageon_bridge_driver);
+
+MODULE_DESCRIPTION("Imageon video bridge");
+MODULE_LICENSE("GPL v2");