diff mbox

mmc: sdhci-pci: set the clear transfer mode register quirk for O2Micro

Message ID 1438583608-17777-1-git-send-email-adam.lee@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Lee Aug. 3, 2015, 6:33 a.m. UTC
This patch fixes MMC not working issue on O2Micro/BayHub Host, which
requires transfer mode register to be cleared when sending no DMA
command.

Signed-off-by: Peter Guo <peter.guo@bayhubtech.com>
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
 drivers/mmc/host/sdhci-pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Adam Lee Aug. 5, 2015, 5:46 a.m. UTC | #1
On Mon, Aug 03, 2015 at 02:33:28PM +0800, Adam Lee wrote:
> This patch fixes MMC not working issue on O2Micro/BayHub Host, which
> requires transfer mode register to be cleared when sending no DMA
> command.
> 
> Signed-off-by: Peter Guo <peter.guo@bayhubtech.com>
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> ---
>  drivers/mmc/host/sdhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
> index 94f54d2..b3b0a3e 100644
> --- a/drivers/mmc/host/sdhci-pci.c
> +++ b/drivers/mmc/host/sdhci-pci.c
> @@ -618,6 +618,7 @@ static int jmicron_resume(struct sdhci_pci_chip *chip)
>  static const struct sdhci_pci_fixes sdhci_o2 = {
>  	.probe = sdhci_pci_o2_probe,
>  	.quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> +	.quirks2 = SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD,
>  	.probe_slot = sdhci_pci_o2_probe_slot,
>  	.resume = sdhci_pci_o2_resume,
>  };
> -- 
> 2.5.0
> 

Hi, Ulf

Please add a cc stable sign off when you apply it, I forgot it, thanks.

"Cc: stable <stable@vger.kernel.org>"
Ulf Hansson Aug. 25, 2015, 12:05 p.m. UTC | #2
On 5 August 2015 at 07:46, Adam Lee <adam.lee@canonical.com> wrote:
> On Mon, Aug 03, 2015 at 02:33:28PM +0800, Adam Lee wrote:
>> This patch fixes MMC not working issue on O2Micro/BayHub Host, which
>> requires transfer mode register to be cleared when sending no DMA
>> command.
>>
>> Signed-off-by: Peter Guo <peter.guo@bayhubtech.com>
>> Signed-off-by: Adam Lee <adam.lee@canonical.com>

Thanks, applied for next and adding the stable tag.

Kind regards
Uffe

>> ---
>>  drivers/mmc/host/sdhci-pci.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
>> index 94f54d2..b3b0a3e 100644
>> --- a/drivers/mmc/host/sdhci-pci.c
>> +++ b/drivers/mmc/host/sdhci-pci.c
>> @@ -618,6 +618,7 @@ static int jmicron_resume(struct sdhci_pci_chip *chip)
>>  static const struct sdhci_pci_fixes sdhci_o2 = {
>>       .probe = sdhci_pci_o2_probe,
>>       .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
>> +     .quirks2 = SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD,
>>       .probe_slot = sdhci_pci_o2_probe_slot,
>>       .resume = sdhci_pci_o2_resume,
>>  };
>> --
>> 2.5.0
>>
>
> Hi, Ulf
>
> Please add a cc stable sign off when you apply it, I forgot it, thanks.
>
> "Cc: stable <stable@vger.kernel.org>"
>
> --
> Adam Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 94f54d2..b3b0a3e 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -618,6 +618,7 @@  static int jmicron_resume(struct sdhci_pci_chip *chip)
 static const struct sdhci_pci_fixes sdhci_o2 = {
 	.probe = sdhci_pci_o2_probe,
 	.quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
+	.quirks2 = SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD,
 	.probe_slot = sdhci_pci_o2_probe_slot,
 	.resume = sdhci_pci_o2_resume,
 };