From patchwork Mon Aug 3 15:24:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6930431 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1FAEEC05AF for ; Mon, 3 Aug 2015 15:24:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82FDA2062D for ; Mon, 3 Aug 2015 15:24:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D89D220628 for ; Mon, 3 Aug 2015 15:24:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 833C86E54C; Mon, 3 Aug 2015 08:24:28 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id F11A86E555 for ; Mon, 3 Aug 2015 08:24:26 -0700 (PDT) Received: by wibud3 with SMTP id ud3so140806980wib.1 for ; Mon, 03 Aug 2015 08:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pqGTPfbSXtkdZvYkIv+7BmV8dHv9wTR9isghySfKz3k=; b=LI/z894i2dw2lZbSQOrAJ9aX7mTN7DPJElC8LJzb+/Lamnyob1GSAhB7AYEuVrQ6Oy g6HUNUwhJVQTxN8OSgPMyGPRAvZwFHa73h1H0s7Dx7VzOUtpgSFpwxphgOhKbM2cp0JF UH/wpOawnSH3BXSjd3AYwse+tMAMf4pgJ/EPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pqGTPfbSXtkdZvYkIv+7BmV8dHv9wTR9isghySfKz3k=; b=dwGAXbbIAp3azxyZSKlhfOA7/qOoPeDJbq55oJX8ZvqAirJyxcFw09qYnSf8rqX0+Y 3tGmyoyvB7d1lHV7MjDW7Wwj+st8T+HliKLqoowf6SSmVIufGymSkBHyLicX5JpjcaGG jmtH0USgzQdORQcXwNole5Z+p2OgjrXtVfT15qK0vLD8jlA70SvkmgBWfr77RVL+WUM5 3JTcj1vCg6HESuniGFooefF43mln3+SYODKrvlOHzdpsja7jwE5AboPZedMjIF3+Ac0B MRg9dABwnsiejrOoSK88aT2h8npQMcRwNn9xikbKRp642TCcg46QxE2PTgtoRKXxuqIj GRiw== X-Gm-Message-State: ALoCoQlBZXE1QIXzV30wPdh++NDq+atrudVcaHhAnuyfgpL1CLXjoS8dPxOLmvB+/+oeHRpfORx8 X-Received: by 10.194.122.97 with SMTP id lr1mr25863200wjb.26.1438615465683; Mon, 03 Aug 2015 08:24:25 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id ez4sm14102677wid.14.2015.08.03.08.24.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 08:24:25 -0700 (PDT) From: Daniel Vetter To: DRI Development , Intel Graphics Development Subject: [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON Date: Mon, 3 Aug 2015 17:24:10 +0200 Message-Id: <1438615451-856-3-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1438615451-856-1-git-send-email-daniel.vetter@ffwll.ch> References: <1438615451-856-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , stable@vger.kernel.org, Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Apparently been in there since forever and fairly easy to hit when hotplugging really fast. I can do that since my mst hub has a manual button to flick the hpd line for reprobing. The resulting WARNING spam isn't pretty. Cc: Dave Airlie Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter Reviewed-by: Thierry Reding --- drivers/gpu/drm/drm_dp_mst_topology.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 778bbb6425b8..b0487c9f018c 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -1294,7 +1294,6 @@ retry: goto retry; } DRM_DEBUG_KMS("failed to dpcd write %d %d\n", tosend, ret); - WARN(1, "fail\n"); return -EIO; }