diff mbox

[V3,14/7] Orangefs: Swap order of include files

Message ID 1438804120-10923-3-git-send-email-hubcap@logtruck.clemson.edu (mailing list archive)
State New, archived
Headers show

Commit Message

Mike Marshall Aug. 5, 2015, 7:48 p.m. UTC 
From: Guenter Roeck <linux@roeck-us.net>

spinlock_types.h requires types from linux/types.h.
Including spinlock_types.h first may result in the following build errors,
as seen with arm:allmodconfig.

arch/arm/include/asm/spinlock_types.h:12:3: error: unknown type name 'u32'
arch/arm/include/asm/spinlock_types.h:16:4: error: unknown type name 'u16'

Fixes: deb4fb58ff73 ("Orangefs: kernel client part 2")
Cc: Mark Brown <broonie@kernel.org>
Cc: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
---
 fs/orangefs/protocol.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mark Brown Aug. 6, 2015, 9:18 a.m. UTC | #1 
On Wed, Aug 05, 2015 at 03:48:40PM -0400, hubcap wrote:
> From: Guenter Roeck <linux@roeck-us.net>
> 
> spinlock_types.h requires types from linux/types.h.
> Including spinlock_types.h first may result in the following build errors,
> as seen with arm:allmodconfig.

Please stop CCing me on this stuff - like I say I'm pretty sure there's
a typo and this was intended to go to someone else.
diff mbox

Patch

diff --git a/fs/orangefs/protocol.h b/fs/orangefs/protocol.h
index ca7cef9..f571be2 100644
--- a/fs/orangefs/protocol.h
+++ b/fs/orangefs/protocol.h
@@ -1,5 +1,5 @@ 
-#include <linux/spinlock_types.h>
 #include <linux/types.h>
+#include <linux/spinlock_types.h>
 #include <linux/slab.h>
 #include <linux/ioctl.h>