| Message ID | 1439497901-14310-3-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 13, 2015 at 01:31:26PM -0700, Jesse Barnes wrote: > Reduces runtime a lot... > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > --- > tests/drv_module_reload_basic | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic > index bb29a64..cf7f2b8 100755 > --- a/tests/drv_module_reload_basic > +++ b/tests/drv_module_reload_basic > @@ -52,7 +52,7 @@ else > fi > > # then try to run something > -if ! $SOURCE_DIR/gem_exec_nop > /dev/null ; then > +if ! $SOURCE_DIR/gem_linear_blits --r basic > /dev/null ; then Please use the full-lenght run-subtest to avoid lots of wtf when we add another option starting with r eventually. With that fixed: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > echo "failed to execute a simple batch after reload" > exit 3 > fi > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 08/14/2015 05:22 AM, Daniel Vetter wrote: > On Thu, Aug 13, 2015 at 01:31:26PM -0700, Jesse Barnes wrote: >> Reduces runtime a lot... >> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> >> --- >> tests/drv_module_reload_basic | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic >> index bb29a64..cf7f2b8 100755 >> --- a/tests/drv_module_reload_basic >> +++ b/tests/drv_module_reload_basic >> @@ -52,7 +52,7 @@ else >> fi >> >> # then try to run something >> -if ! $SOURCE_DIR/gem_exec_nop > /dev/null ; then >> +if ! $SOURCE_DIR/gem_linear_blits --r basic > /dev/null ; then > > Please use the full-lenght run-subtest to avoid lots of wtf when we add > another option starting with r eventually. With that fixed: > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Done, thanks. Jesse
diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic index bb29a64..cf7f2b8 100755 --- a/tests/drv_module_reload_basic +++ b/tests/drv_module_reload_basic @@ -52,7 +52,7 @@ else fi # then try to run something -if ! $SOURCE_DIR/gem_exec_nop > /dev/null ; then +if ! $SOURCE_DIR/gem_linear_blits --r basic > /dev/null ; then echo "failed to execute a simple batch after reload" exit 3 fi
Reduces runtime a lot... Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- tests/drv_module_reload_basic | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)