thermal: underflow bug in imx_set_trip_temp()
diff mbox

Message ID 20150821084909.GD25369@mwanda
State Accepted
Delegated to: Eduardo Valentin
Headers show

Commit Message

Dan Carpenter Aug. 21, 2015, 8:49 a.m. UTC
We recently changed this from unsigned long to int so it introduced an
underflow bug.

Fixes: 17e8351a7739 ('thermal: consistently use int for temperatures')
Signed-off-by: Dan Carpenter <>

To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to
More majordomo info at

diff mbox

diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 4bec1d3..7a06465 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -288,7 +288,7 @@  static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip,
 	if (trip == IMX_TRIP_CRITICAL)
 		return -EPERM;
-	if (temp > IMX_TEMP_PASSIVE)
+	if (temp < 0 || temp > IMX_TEMP_PASSIVE)
 		return -EINVAL;
 	data->temp_passive = temp;