| Message ID | 1440773507-21799-1-git-send-email-mika.kuoppala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 28 Aug 2015, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote: > Use the pre configured pci device from config also > in write path. > > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> > --- > tools/intel_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/intel_reg.c b/tools/intel_reg.c > index 190aa5b..2b60a83 100644 > --- a/tools/intel_reg.c > +++ b/tools/intel_reg.c > @@ -439,7 +439,7 @@ static int intel_reg_write(struct config *config, int argc, char *argv[]) > return EXIT_FAILURE; > } > > - intel_register_access_init(intel_get_pci_device(), 0); > + intel_register_access_init(config->pci_dev, 0); Whoops, my bad. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > for (i = 1; i < argc; i += 2) { > struct reg reg; > -- > 2.1.4 >
On 28 August 2015 at 16:16, Jani Nikula <jani.nikula@intel.com> wrote: > On Fri, 28 Aug 2015, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote: >> Use the pre configured pci device from config also >> in write path. >> >> Cc: Jani Nikula <jani.nikula@intel.com> >> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> >> --- >> tools/intel_reg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/intel_reg.c b/tools/intel_reg.c >> index 190aa5b..2b60a83 100644 >> --- a/tools/intel_reg.c >> +++ b/tools/intel_reg.c >> @@ -439,7 +439,7 @@ static int intel_reg_write(struct config *config, int argc, char *argv[]) >> return EXIT_FAILURE; >> } >> >> - intel_register_access_init(intel_get_pci_device(), 0); >> + intel_register_access_init(config->pci_dev, 0); > > Whoops, my bad. > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Thanks, I've pushed this patch. The other two patches in this series can be pushed once any of the review comments have been addressed. > > >> >> for (i = 1; i < argc; i += 2) { >> struct reg reg; >> -- >> 2.1.4 >> > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tools/intel_reg.c b/tools/intel_reg.c index 190aa5b..2b60a83 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c @@ -439,7 +439,7 @@ static int intel_reg_write(struct config *config, int argc, char *argv[]) return EXIT_FAILURE; } - intel_register_access_init(intel_get_pci_device(), 0); + intel_register_access_init(config->pci_dev, 0); for (i = 1; i < argc; i += 2) { struct reg reg;
Use the pre configured pci device from config also in write path. Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)