| Message ID | 9f8845993df848df703f3ab177745ea54c30e828.1440902901.git.mchehab@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mauro, Thank you for the patch. On Sunday 30 August 2015 00:06:45 Mauro Carvalho Chehab wrote: > This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating > some subdevs with a non-existing type. > > As this is a sensor driver, the proper type is likely > MEDIA_ENT_T_CAM_SENSOR. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index c81bfbfea32f..abae37321c0c > 100644 > --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > @@ -1688,7 +1688,7 @@ static int s5c73m3_probe(struct i2c_client *client, > > state->sensor_pads[S5C73M3_JPEG_PAD].flags = MEDIA_PAD_FL_SOURCE; > state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE; > - sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; > + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; As explained in my review of "s5k5baf: fix subdev type", this is correct... > ret = media_entity_init(&sd->entity, S5C73M3_NUM_PADS, > state->sensor_pads); > @@ -1704,7 +1704,7 @@ static int s5c73m3_probe(struct i2c_client *client, > state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK; > state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK; > state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE; > - oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; > + oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ... but this isn't. > ret = media_entity_init(&oif_sd->entity, OIF_NUM_PADS, > state->oif_pads);
Em Sun, 06 Dec 2015 03:57:56 +0200 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:45 Mauro Carvalho Chehab wrote: > > This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating > > some subdevs with a non-existing type. > > > > As this is a sensor driver, the proper type is likely > > MEDIA_ENT_T_CAM_SENSOR. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > > > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > > b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index c81bfbfea32f..abae37321c0c > > 100644 > > --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > > +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > > @@ -1688,7 +1688,7 @@ static int s5c73m3_probe(struct i2c_client *client, > > > > state->sensor_pads[S5C73M3_JPEG_PAD].flags = MEDIA_PAD_FL_SOURCE; > > state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE; > > - sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; > > + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; > > As explained in my review of "s5k5baf: fix subdev type", this is correct... > > > ret = media_entity_init(&sd->entity, S5C73M3_NUM_PADS, > > state->sensor_pads); > > @@ -1704,7 +1704,7 @@ static int s5c73m3_probe(struct i2c_client *client, > > state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK; > > state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK; > > state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE; > > - oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; > > + oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; > > ... but this isn't. Ok. Replacing this hunk by: - oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; + oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN; > > > ret = media_entity_init(&oif_sd->entity, OIF_NUM_PADS, > > state->oif_pads); > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index c81bfbfea32f..abae37321c0c 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -1688,7 +1688,7 @@ static int s5c73m3_probe(struct i2c_client *client, state->sensor_pads[S5C73M3_JPEG_PAD].flags = MEDIA_PAD_FL_SOURCE; state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE; - sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ret = media_entity_init(&sd->entity, S5C73M3_NUM_PADS, state->sensor_pads); @@ -1704,7 +1704,7 @@ static int s5c73m3_probe(struct i2c_client *client, state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK; state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK; state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE; - oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; + oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ret = media_entity_init(&oif_sd->entity, OIF_NUM_PADS, state->oif_pads);
This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating some subdevs with a non-existing type. As this is a sensor driver, the proper type is likely MEDIA_ENT_T_CAM_SENSOR. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>