From patchwork Wed Sep 2 23:27:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru M Stan X-Patchwork-Id: 7113981 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F1CF4BEEC1 for ; Wed, 2 Sep 2015 23:29:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5E71C206B0 for ; Wed, 2 Sep 2015 23:29:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33202206AD for ; Wed, 2 Sep 2015 23:29:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXHTV-0005vZ-UZ; Wed, 02 Sep 2015 23:29:53 +0000 Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXHTT-0005ou-Ut for linux-rockchip@lists.infradead.org; Wed, 02 Sep 2015 23:29:52 +0000 Received: by pacex6 with SMTP id ex6so20854406pac.0 for ; Wed, 02 Sep 2015 16:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PAmSkyOotqkS3v6DWKDEpow6txfNqERGUehYyTg4DEQ=; b=I+pv+NYRCTqKBAG9IvT3akiSld0qVgHHiPTxoq65kiqfGVe8zCbILBWgY8iUzz58je 2SqI46MI2fJAQuKwRHxFuMvcRKt7W/6tVWJqs5WMPQt8HePi8h/aSCxnGtcsEPS4wNMI XSiA3mxGFqh+fxKI4jaFS+WEcsFFtEfQ1fwgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PAmSkyOotqkS3v6DWKDEpow6txfNqERGUehYyTg4DEQ=; b=EzDSc42+M1PX8fhuxtRpqomLcBcwJW79XU5xdeNxkKcVHozB/dRUJHaDKeyRLLiSbQ KU/PDyBwYhT19PEl0p9HMIwobSDU0l+pSwX12scIVvKmbuTl9XQy9gECSvSKwfkzhFyn J+6SrwbJ73okxhdQoGj0MhiO3Ytuio0GQhxg6hyM7Th3OWF3oj29ii51LN71H+BO4hvO yvs45cA1Ix4yOaWzav83vXRPZQaOcWxqhuCvQirVwm9rFfd7LCBTlAn0dqrzU8+bB7fP gej5Bua5J861KMzEZL9wRBZjXTDVxkhA/aDNBf4z5BXssX7D5471WvL5hmP7NfLj+bBH VmSg== X-Gm-Message-State: ALoCoQly0Wxf2RQBLsDopVGsbkPvVW/cH0JInN8PLW7Ty8pxJm1yFf4BZ+B3KQe+u+2ezaI2USvD X-Received: by 10.68.197.196 with SMTP id iw4mr60130504pbc.153.1441236571372; Wed, 02 Sep 2015 16:29:31 -0700 (PDT) Received: from amstan.mtv.corp.google.com ([100.96.109.27]) by smtp.gmail.com with ESMTPSA id y15sm22844432pbt.90.2015.09.02.16.29.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Sep 2015 16:29:30 -0700 (PDT) From: Alexandru M Stan To: Heiko Stuebner Subject: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 Date: Wed, 2 Sep 2015 16:27:58 -0700 Message-Id: <1441236479-4941-2-git-send-email-amstan@chromium.org> X-Mailer: git-send-email 2.5.0.457.gab17608 In-Reply-To: <1441236479-4941-1-git-send-email-amstan@chromium.org> References: <1441236479-4941-1-git-send-email-amstan@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150902_162952_031516_5906069A X-CRM114-Status: GOOD ( 13.01 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandru M Stan , Jeffy Chen , Douglas Anderson , FUKAUMI Naoki , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Neil Hendin , Romain Perier , linux-arm-kernel@lists.infradead.org, Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The flow control lines from a user accessible UART are optional, the user might not have anything connected to those pins. In order to prevent random interrupts happening and noise affecting the cts pin should be pulled up. Note that the default state for that pin on the rk3288 is pulled up, so this patch merely restores them. This is similar to what we're already doing with the RX pin, so it should be safe. At worst it might be a slightly higher power usage (through ~50 kohms) when the cts is low. Suggested-by: Neil Hendin Signed-off-by: Alexandru M Stan Reviewed-by: Douglas Anderson --- Changes in v2: None arch/arm/boot/dts/rk3288.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 906e938..0e8fd53 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -1211,7 +1211,7 @@ }; uart0_cts: uart0-cts { - rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_up>; }; uart0_rts: uart0-rts { @@ -1226,7 +1226,7 @@ }; uart1_cts: uart1-cts { - rockchip,pins = <5 10 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <5 10 RK_FUNC_1 &pcfg_pull_up>; }; uart1_rts: uart1-rts { @@ -1249,7 +1249,7 @@ }; uart3_cts: uart3-cts { - rockchip,pins = <7 9 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <7 9 RK_FUNC_1 &pcfg_pull_up>; }; uart3_rts: uart3-rts { @@ -1264,7 +1264,7 @@ }; uart4_cts: uart4-cts { - rockchip,pins = <5 14 3 &pcfg_pull_none>; + rockchip,pins = <5 14 3 &pcfg_pull_up>; }; uart4_rts: uart4-rts {