diff mbox

ARM: dts: am57xx-beagle-x15: Update Phy supplies

Message ID 1441308226-26690-1-git-send-email-nm@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nishanth Menon Sept. 3, 2015, 7:23 p.m. UTC
Originally, all the SoC PHY rails were supplied by LDO3. However, as a
result of characterization, it was determined that this posed a risk in
extreme load  conditions. Hence the PHY rails are split between two
different LDOs. Update the related node as a result

LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3
LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie

NOTE: We break compatibility with pre-production boards with this change
since, the PMIC LDO4 is disabled at OTP level.

The new configuration is the plan of record and all pre-production
boards are supposed to be replaced with the latest boards matching the
mentioned configuration.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comments

Nishanth Menon Sept. 16, 2015, 3:11 p.m. UTC | #1
Hi Tony,

On 09/03/2015 02:23 PM, Nishanth Menon wrote:
> Originally, all the SoC PHY rails were supplied by LDO3. However, as a
> result of characterization, it was determined that this posed a risk in
> extreme load  conditions. Hence the PHY rails are split between two
> different LDOs. Update the related node as a result
> 
> LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3
> LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie
> 
> NOTE: We break compatibility with pre-production boards with this change
> since, the PMIC LDO4 is disabled at OTP level.
> 
> The new configuration is the plan of record and all pre-production
> boards are supposed to be replaced with the latest boards matching the
> mentioned configuration.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---

Gentle ping. Some very few 10 something boards have been created and
stopped production till the latest modifications were done (PMIC USB
interrupt, LDO4 etc) - and all of those boards are now getting
scrapped.. If there are any (as per tracking information, there should
not be any), TI should be contacted to have them replaced.

Is it possible for us to consider this patch in 4.3 cycle - given that
we are this close, might have been great to see 4.3 vanilla function on
the production platform.

>  arch/arm/boot/dts/am57xx-beagle-x15.dts |   13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 3a05b94f59ed..ede7fb73c717 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -432,7 +432,7 @@
>  				};
>  
>  				ldo3_reg: ldo3 {
> -					/* VDDA_1V8_PHY */
> +					/* VDDA_1V8_PHYA */
>  					regulator-name = "ldo3";
>  					regulator-min-microvolt = <1800000>;
>  					regulator-max-microvolt = <1800000>;
> @@ -440,6 +440,15 @@
>  					regulator-boot-on;
>  				};
>  
> +				ldo4_reg: ldo4 {
> +					/* VDDA_1V8_PHYB */
> +					regulator-name = "ldo4";
> +					regulator-min-microvolt = <1800000>;
> +					regulator-max-microvolt = <1800000>;
> +					regulator-always-on;
> +					regulator-boot-on;
> +				};
> +
>  				ldo9_reg: ldo9 {
>  					/* VDD_RTC */
>  					regulator-name = "ldo9";
> @@ -681,7 +690,7 @@
>  
>  &hdmi {
>  	status = "ok";
> -	vdda-supply = <&ldo3_reg>;
> +	vdda-supply = <&ldo4_reg>;
>  
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&hdmi_pins>;
>
Tony Lindgren Sept. 16, 2015, 11:57 p.m. UTC | #2
* Nishanth Menon <nm@ti.com> [150916 08:15]:
> Hi Tony,
> 
> On 09/03/2015 02:23 PM, Nishanth Menon wrote:
> > Originally, all the SoC PHY rails were supplied by LDO3. However, as a
> > result of characterization, it was determined that this posed a risk in
> > extreme load  conditions. Hence the PHY rails are split between two
> > different LDOs. Update the related node as a result
> > 
> > LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3
> > LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie
> > 
> > NOTE: We break compatibility with pre-production boards with this change
> > since, the PMIC LDO4 is disabled at OTP level.
> > 
> > The new configuration is the plan of record and all pre-production
> > boards are supposed to be replaced with the latest boards matching the
> > mentioned configuration.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> 
> Gentle ping. Some very few 10 something boards have been created and
> stopped production till the latest modifications were done (PMIC USB
> interrupt, LDO4 etc) - and all of those boards are now getting
> scrapped.. If there are any (as per tracking information, there should
> not be any), TI should be contacted to have them replaced.

Sounds OK to me as they are TI internal protos.
 
> Is it possible for us to consider this patch in 4.3 cycle - given that
> we are this close, might have been great to see 4.3 vanilla function on
> the production platform.

Applying into omap-for-v4.3/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index 3a05b94f59ed..ede7fb73c717 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -432,7 +432,7 @@ 
 				};
 
 				ldo3_reg: ldo3 {
-					/* VDDA_1V8_PHY */
+					/* VDDA_1V8_PHYA */
 					regulator-name = "ldo3";
 					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
@@ -440,6 +440,15 @@ 
 					regulator-boot-on;
 				};
 
+				ldo4_reg: ldo4 {
+					/* VDDA_1V8_PHYB */
+					regulator-name = "ldo4";
+					regulator-min-microvolt = <1800000>;
+					regulator-max-microvolt = <1800000>;
+					regulator-always-on;
+					regulator-boot-on;
+				};
+
 				ldo9_reg: ldo9 {
 					/* VDD_RTC */
 					regulator-name = "ldo9";
@@ -681,7 +690,7 @@ 
 
 &hdmi {
 	status = "ok";
-	vdda-supply = <&ldo3_reg>;
+	vdda-supply = <&ldo4_reg>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&hdmi_pins>;