| Message ID | 1441753160-26476-1-git-send-email-ross.zwisler@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote: > The big warning comment that is currently at the end of struct > inode_operations was added as part of this commit: > > 4aa7c6346be3 ("vfs: add i_op->dentry_open()") > > It was added to warn people not to use the newly added 'dentry_open' > function pointer. > > This function pointer was removed as part of this commit: > > 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and > f_inode to the underlay") > > The comment was left behind and now refers to nothing, so remove it. > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > --- > include/linux/fs.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index b2f9b9c..b3ff479 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1679,8 +1679,6 @@ struct inode_operations { > umode_t create_mode, int *opened); > int (*tmpfile) (struct inode *, struct dentry *, umode_t); > int (*set_acl)(struct inode *, struct posix_acl *, int); > - > - /* WARNING: probably going away soon, do not use! */ > } ____cacheline_aligned; > > ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, Ping? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 08-10-15 17:07:20, Ross Zwisler wrote: > On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote: > > The big warning comment that is currently at the end of struct > > inode_operations was added as part of this commit: > > > > 4aa7c6346be3 ("vfs: add i_op->dentry_open()") > > > > It was added to warn people not to use the newly added 'dentry_open' > > function pointer. > > > > This function pointer was removed as part of this commit: > > > > 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and > > f_inode to the underlay") > > > > The comment was left behind and now refers to nothing, so remove it. > > > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > > --- > > include/linux/fs.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index b2f9b9c..b3ff479 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -1679,8 +1679,6 @@ struct inode_operations { > > umode_t create_mode, int *opened); > > int (*tmpfile) (struct inode *, struct dentry *, umode_t); > > int (*set_acl)(struct inode *, struct posix_acl *, int); > > - > > - /* WARNING: probably going away soon, do not use! */ > > } ____cacheline_aligned; > > > > ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, > > Ping? Probably should go to Al. Added to CC. Honza
diff --git a/include/linux/fs.h b/include/linux/fs.h index b2f9b9c..b3ff479 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1679,8 +1679,6 @@ struct inode_operations { umode_t create_mode, int *opened); int (*tmpfile) (struct inode *, struct dentry *, umode_t); int (*set_acl)(struct inode *, struct posix_acl *, int); - - /* WARNING: probably going away soon, do not use! */ } ____cacheline_aligned; ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,
The big warning comment that is currently at the end of struct inode_operations was added as part of this commit: 4aa7c6346be3 ("vfs: add i_op->dentry_open()") It was added to warn people not to use the newly added 'dentry_open' function pointer. This function pointer was removed as part of this commit: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay") The comment was left behind and now refers to nothing, so remove it. Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> --- include/linux/fs.h | 2 -- 1 file changed, 2 deletions(-)