From patchwork Thu Sep 10 20:39:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7155831 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9D736BF036 for ; Thu, 10 Sep 2015 20:36:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D65A42086F for ; Thu, 10 Sep 2015 20:36:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id CE99A20849 for ; Thu, 10 Sep 2015 20:36:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA2FE6E08D; Thu, 10 Sep 2015 13:36:45 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDEBC6E08D for ; Thu, 10 Sep 2015 13:36:44 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so42069359wic.0 for ; Thu, 10 Sep 2015 13:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=mHdfkIpgqF/lO/qJUCdERDwclvnw+/cY4OpARlJmIzs=; b=EC5pCyAn1TAZ9CUkBuHfOzhZP4YhTIyWkzqY6uVP8PVp4S0gTkqFLjE0E5tXmMwFFr JfwHgwT9o1A5ZP2oI90njL8zwRXXI29BDsg+p6wZXaWkLpNi+oLlYwrbNaXoL/3pxGEC mwF9gE5iM2oGqxMZwXOhEj15KN2yr/vBIyYrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mHdfkIpgqF/lO/qJUCdERDwclvnw+/cY4OpARlJmIzs=; b=NveAH9VYkRnGHh+tgoYVmxkEED8QTC7GR2Dwl/PBxRJpXyQVc8CsffLvwLcuSD/OwO Q1fU69TerrAfpeyBDRDwWbq4puKGBCeGLxPqe9Zlpas+JrEbyVSAQTEkAfqEDi+IKMJh 8mdObfk/ofQq5m3YJUjjM5KVlCyGbroLiWsGqTNj7ATMWua7EWlB824Nr2g2b8zywdKp BWpRwKtY8SozALHTGHKw/jEvZn2upwVHQazpE9pzrYpfdMDiYwyCHmMYxqpiSkRqh5lq 4GpZWiB0ivEtqHcCPixfEOnv6VnUYFgtEniU2YI+XT9FQQV8qos3IP0E8gmlYhZyqxMS u9aQ== X-Gm-Message-State: ALoCoQkRbRHN4KDGyT835hSk1a+875FSU+vsl/HfjuWJjk3l3LWf4yfRvBofTGKSA5SeUHtlhZIa X-Received: by 10.194.179.6 with SMTP id dc6mr73332721wjc.39.1441917403054; Thu, 10 Sep 2015 13:36:43 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id ry1sm17438388wjb.24.2015.09.10.13.36.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Sep 2015 13:36:42 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development , DRI Development Date: Thu, 10 Sep 2015 22:39:22 +0200 Message-Id: <1441917562-18749-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 Cc: Daniel Vetter , Daniel Vetter Subject: [Intel-gfx] [PATCH] drm: Nuke drm_framebuffer->helper_private X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's completely unused and there's really no reason for this: - drm_framebuffer structures are invariant after creation, no need for helpers to manipulate them. - drm_framebuffer structures should just be embedded (and that's what all the drivers do). Stumbled over this since some folks are apparently concerned with the overhead of struct drm_framebuffer and this is an easy 8 byte saving. More could be gained by ditching the legacy fields and recomputing stuff from the fourcc value. But that would require some drm-wide cocci and real justification. Cc: gary.k.smith@intel.com Signed-off-by: Daniel Vetter Reviewed-by: David Herrmann --- include/drm/drm_crtc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 75f49c1ef8bb..c0366e9152e2 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -210,8 +210,6 @@ struct drm_framebuffer { int flags; uint32_t pixel_format; /* fourcc format */ struct list_head filp_head; - /* if you are using the helper */ - void *helper_private; }; struct drm_property_blob {