From patchwork Mon Sep 14 13:45:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 7176311 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 04C9ABF036 for ; Mon, 14 Sep 2015 13:49:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 08B7B206E5 for ; Mon, 14 Sep 2015 13:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02E29206E4 for ; Mon, 14 Sep 2015 13:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755662AbbINNtB (ORCPT ); Mon, 14 Sep 2015 09:49:01 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35446 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513AbbINNqF (ORCPT ); Mon, 14 Sep 2015 09:46:05 -0400 Received: by ykdu9 with SMTP id u9so153506445ykd.2 for ; Mon, 14 Sep 2015 06:46:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FOM35biItsZahLFZYaA6PWQqQkTm4XGhBtrr+zKaKrI=; b=jvTLDE/mMcpREABJ1bmEqLm4EzYAm+u97DJDPe5B2VNK+XWU9CCNWUEZDY0d6BrYg1 yQLkHP8Y7l5kDvOI7njLDdYGOaTmH8DlGvSDA1XZpq7VkM/nVqCxPL6bFOWZ5FzisKPn 45yeRsai3ySKYAOpWT2az5Zj8qnlc5MQZCkrdeIFFapj3EYvhw18GLa+m3JyxX4HZ9X4 MecTy+5RQfIklNJC2jlIJHVAAcJYM6eoksMZnGpEKirbIASGjXt0sE5PUI/9Z9VqGd6s tqMc4aSDaCNSlHS8kaHXwh9j61lPV/cgNHINTDl7+0msQflADOvTIfKJM7FIJ0as5XzA hQPg== X-Gm-Message-State: ALoCoQl37dCqKjD+efbVMo0XvDzBxA1qdkkPdEDpWZgCR1MqkE38BRLl2gM/P8B8wvgvIIYclE5C X-Received: by 10.170.157.5 with SMTP id y5mr13438833ykc.28.1442238365180; Mon, 14 Sep 2015 06:46:05 -0700 (PDT) Received: from tlielax.poochiereds.net ([2606:a000:1105:8e:3a60:77ff:fe93:a95d]) by smtp.googlemail.com with ESMTPSA id a4sm9601131ywc.15.2015.09.14.06.46.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2015 06:46:04 -0700 (PDT) From: Jeff Layton X-Google-Original-From: Jeff Layton To: Al Viro Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] fs: export flush_delayed_fput Date: Mon, 14 Sep 2015 09:45:55 -0400 Message-Id: <1442238355-8203-5-git-send-email-jeff.layton@primarydata.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1442238355-8203-1-git-send-email-jeff.layton@primarydata.com> References: <1442238355-8203-1-git-send-email-jeff.layton@primarydata.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ...and clean up the comments over it a bit. Signed-off-by: Jeff Layton --- fs/file_table.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 1ad2e3fd2064..2b145b513274 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -246,19 +246,19 @@ static void ____fput(struct callback_head *work) static DECLARE_DELAYED_WORK(delayed_fput_work, delayed_fput); /* - * If kernel thread really needs to have the final fput() it has done - * to complete, call this. The only user right now is the boot - we - * *do* need to make sure our writes to binaries on initramfs has - * not left us with opened struct file waiting for __fput() - execve() - * won't work without that. Please, don't add more callers without - * very good reasons; in particular, never call that with locks - * held and never call that from a thread that might need to do - * some work on any kind of umount. + * If kernel thread or task that has used fput_queue really needs to have the + * final fput() it has done to complete, call this. The only user right now is + * the boot - we *do* need to make sure our writes to binaries on initramfs has + * not left us with opened struct file waiting for __fput() - execve() won't + * work without that. Please, don't add more callers without very good + * reasons; in particular, never call that with locks held and never call that + * from a thread that might need to do some work on any kind of umount. */ void flush_delayed_fput(void) { flush_delayed_work(&delayed_fput_work); } +EXPORT_SYMBOL(flush_delayed_fput); /** * fput - put a struct file reference