diff mbox

[1/4] drm/exynos: remove unnecessary NULL assignment

Message ID 1442381375-540-1-git-send-email-jy0922.shim@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joonyoung Shim Sept. 16, 2015, 5:29 a.m. UTC
They will be freed right or was freed already, so NULL assignment is
unnecessary.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Gustavo Padovan Sept. 21, 2015, 4:10 p.m. UTC | #1
Hi Joonyoung,

2015-09-16 Joonyoung Shim <jy0922.shim@samsung.com>:

> They will be freed right or was freed already, so NULL assignment is
> unnecessary.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index f12fbc3..8dce40d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -117,8 +117,6 @@  static void exynos_drm_free_buf(struct exynos_drm_gem_obj *obj)
 	} else
 		dma_free_attrs(dev->dev, obj->size, obj->pages,
 				(dma_addr_t)obj->dma_addr, &obj->dma_attrs);
-
-	obj->dma_addr = (dma_addr_t)NULL;
 }
 
 static int exynos_drm_gem_handle_create(struct drm_gem_object *obj,
@@ -167,7 +165,6 @@  out:
 	drm_gem_object_release(obj);
 
 	kfree(exynos_gem_obj);
-	exynos_gem_obj = NULL;
 }
 
 unsigned long exynos_drm_gem_get_size(struct drm_device *dev,