[4/4] ASoC: wm8960: correct the max register value of mic boost pga
diff mbox

Message ID 119b66684faaf7ff237dfccc864ec8e0561aefd3.1442566367.git.zidan.wang@freescale.com
State Accepted
Commit 8524bb0c7ac688a3cd6ba12dae6104c54d0566b9
Headers show

Commit Message

Zidan Wang Sept. 18, 2015, 9:19 a.m. UTC
the max register value of mic boost pga should be 3.

Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
---
 sound/soc/codecs/wm8960.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Charles Keepax Sept. 18, 2015, 12:57 p.m. UTC | #1
On Fri, Sep 18, 2015 at 05:19:43PM +0800, Zidan Wang wrote:
> the max register value of mic boost pga should be 3.
> 
> Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
Mark Brown Sept. 19, 2015, 2:50 p.m. UTC | #2
On Fri, Sep 18, 2015 at 05:19:43PM +0800, Zidan Wang wrote:
> the max register value of mic boost pga should be 3.

Please don't send random unrelated changes as a single series, if the
changes don't form part of a cohesive whole either working on the same
code or doing the same thing then just send a number of separate
patches.  This makes lots of parts of the workflow work better since
people won't assume interdependencies that don't exist.

Patch
diff mbox

diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 6975390..dbd8840 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -240,9 +240,9 @@  SOC_SINGLE_TLV("Left Input Boost Mixer LINPUT3 Volume",
 SOC_SINGLE_TLV("Left Input Boost Mixer LINPUT2 Volume",
 	       WM8960_INBMIX2, 1, 7, 0, lineinboost_tlv),
 SOC_SINGLE_TLV("Right Input Boost Mixer RINPUT1 Volume",
-		WM8960_RINPATH, 4, 4, 0, micboost_tlv),
+		WM8960_RINPATH, 4, 3, 0, micboost_tlv),
 SOC_SINGLE_TLV("Left Input Boost Mixer LINPUT1 Volume",
-		WM8960_LINPATH, 4, 4, 0, micboost_tlv),
+		WM8960_LINPATH, 4, 3, 0, micboost_tlv),
 
 SOC_DOUBLE_R_TLV("Playback Volume", WM8960_LDAC, WM8960_RDAC,
 		 0, 255, 0, dac_tlv),