PM / AVS: rockchip-io: Fix module autoload for OF platform driver
diff mbox

Message ID 20150918165258.GA27398@goodgumbo.baconseed.org
State New
Headers show

Commit Message

Luis de Bethencourt Sept. 18, 2015, 4:52 p.m. UTC
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/power/avs/rockchip-io-domain.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stuebner Oct. 2, 2015, 2:08 p.m. UTC | #1
Am Freitag, 18. September 2015, 18:52:58 schrieb Luis de Bethencourt:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

looks obviously correct.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


depending on how Kevin wants to handle that single patch, you might want to 
resent it with Rafael Wysocki in the to-list though


Heiko

> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/power/avs/rockchip-io-domain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/avs/rockchip-io-domain.c
> b/drivers/power/avs/rockchip-io-domain.c index 2e30002..8099456 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -271,6 +271,7 @@ static const struct of_device_id
> rockchip_iodomain_match[] = { },
>  	{ /* sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
> 
>  static int rockchip_iodomain_probe(struct platform_device *pdev)
>  {

Patch
diff mbox

diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 2e30002..8099456 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -271,6 +271,7 @@  static const struct of_device_id rockchip_iodomain_match[] = {
 	},
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
 
 static int rockchip_iodomain_probe(struct platform_device *pdev)
 {