| Message ID | 1443016847-29857-1-git-send-email-kgroeneveld@lenbrook.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 23, 2015 at 10:00:47AM -0400, Kevin Groeneveld wrote: > The bits within each byte of the hardware registers for the channel status > bits are reversed. Therefore when the channel status is read from the > hardware we need to reverse the bits. > > The code which writes the channel status bits for the TX already correctly > reverses the bits. This patch implements similar functionality for the RX. > > I have tested this patch running on imx6 using several different SPDIF > source devices. > > Signed-off-by: Kevin Groeneveld <kgroeneveld@lenbrook.com> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Thank you > --- > sound/soc/fsl/fsl_spdif.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c > index ab729f2..e84e839 100644 > --- a/sound/soc/fsl/fsl_spdif.c > +++ b/sound/soc/fsl/fsl_spdif.c > @@ -676,14 +676,14 @@ static int fsl_spdif_capture_get(struct snd_kcontrol *kcontrol, > return -EAGAIN; > > regmap_read(regmap, REG_SPDIF_SRCSH, &cstatus); > - ucontrol->value.iec958.status[0] = (cstatus >> 16) & 0xFF; > - ucontrol->value.iec958.status[1] = (cstatus >> 8) & 0xFF; > - ucontrol->value.iec958.status[2] = cstatus & 0xFF; > + ucontrol->value.iec958.status[0] = bitrev8((cstatus >> 16) & 0xFF); > + ucontrol->value.iec958.status[1] = bitrev8((cstatus >> 8) & 0xFF); > + ucontrol->value.iec958.status[2] = bitrev8(cstatus & 0xFF); > > regmap_read(regmap, REG_SPDIF_SRCSL, &cstatus); > - ucontrol->value.iec958.status[3] = (cstatus >> 16) & 0xFF; > - ucontrol->value.iec958.status[4] = (cstatus >> 8) & 0xFF; > - ucontrol->value.iec958.status[5] = cstatus & 0xFF; > + ucontrol->value.iec958.status[3] = bitrev8((cstatus >> 16) & 0xFF); > + ucontrol->value.iec958.status[4] = bitrev8((cstatus >> 8) & 0xFF); > + ucontrol->value.iec958.status[5] = bitrev8(cstatus & 0xFF); > > /* Clear intr */ > regmap_write(regmap, REG_SPDIF_SIC, INT_CNEW); > -- > 1.7.4.1 >
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index ab729f2..e84e839 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -676,14 +676,14 @@ static int fsl_spdif_capture_get(struct snd_kcontrol *kcontrol, return -EAGAIN; regmap_read(regmap, REG_SPDIF_SRCSH, &cstatus); - ucontrol->value.iec958.status[0] = (cstatus >> 16) & 0xFF; - ucontrol->value.iec958.status[1] = (cstatus >> 8) & 0xFF; - ucontrol->value.iec958.status[2] = cstatus & 0xFF; + ucontrol->value.iec958.status[0] = bitrev8((cstatus >> 16) & 0xFF); + ucontrol->value.iec958.status[1] = bitrev8((cstatus >> 8) & 0xFF); + ucontrol->value.iec958.status[2] = bitrev8(cstatus & 0xFF); regmap_read(regmap, REG_SPDIF_SRCSL, &cstatus); - ucontrol->value.iec958.status[3] = (cstatus >> 16) & 0xFF; - ucontrol->value.iec958.status[4] = (cstatus >> 8) & 0xFF; - ucontrol->value.iec958.status[5] = cstatus & 0xFF; + ucontrol->value.iec958.status[3] = bitrev8((cstatus >> 16) & 0xFF); + ucontrol->value.iec958.status[4] = bitrev8((cstatus >> 8) & 0xFF); + ucontrol->value.iec958.status[5] = bitrev8(cstatus & 0xFF); /* Clear intr */ regmap_write(regmap, REG_SPDIF_SIC, INT_CNEW);
The bits within each byte of the hardware registers for the channel status bits are reversed. Therefore when the channel status is read from the hardware we need to reverse the bits. The code which writes the channel status bits for the TX already correctly reverses the bits. This patch implements similar functionality for the RX. I have tested this patch running on imx6 using several different SPDIF source devices. Signed-off-by: Kevin Groeneveld <kgroeneveld@lenbrook.com> --- sound/soc/fsl/fsl_spdif.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)