diff mbox

drm/gma500: Remove DP_LINK_STATUS_SIZE redefinition

Message ID 1443082052-24002-1-git-send-email-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thierry Reding Sept. 24, 2015, 8:07 a.m. UTC
From: Thierry Reding <treding@nvidia.com>

The DRM/DP helpers already contain a definition for this macro. Remove
the duplicate in the GMA500 driver to avoid having to keep both updated
synchronously.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Patrik Jakobsson Sept. 24, 2015, 11:44 a.m. UTC | #1
On Thu, Sep 24, 2015 at 10:07 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The DRM/DP helpers already contain a definition for this macro. Remove
> the duplicate in the GMA500 driver to avoid having to keep both updated
> synchronously.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

> ---
>  drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> index 0fafb8e2483a..17cea400ae32 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> @@ -247,7 +247,6 @@ i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
>
>  #define wait_for(COND, MS) _wait_for(COND, MS, 1)
>
> -#define DP_LINK_STATUS_SIZE    6
>  #define DP_LINK_CHECK_TIMEOUT  (10 * 1000)
>
>  #define DP_LINK_CONFIGURATION_SIZE     9
> --
> 2.5.0
>
Daniel Vetter Sept. 24, 2015, 3:15 p.m. UTC | #2
On Thu, Sep 24, 2015 at 01:44:08PM +0200, Patrik Jakobsson wrote:
> On Thu, Sep 24, 2015 at 10:07 AM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The DRM/DP helpers already contain a definition for this macro. Remove
> > the duplicate in the GMA500 driver to avoid having to keep both updated
> > synchronously.
> >
> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

Applied to drm-misc, thanks.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> > index 0fafb8e2483a..17cea400ae32 100644
> > --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> > +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> > @@ -247,7 +247,6 @@ i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
> >
> >  #define wait_for(COND, MS) _wait_for(COND, MS, 1)
> >
> > -#define DP_LINK_STATUS_SIZE    6
> >  #define DP_LINK_CHECK_TIMEOUT  (10 * 1000)
> >
> >  #define DP_LINK_CONFIGURATION_SIZE     9
> > --
> > 2.5.0
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
index 0fafb8e2483a..17cea400ae32 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
@@ -247,7 +247,6 @@  i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
 
 #define wait_for(COND, MS) _wait_for(COND, MS, 1)
 
-#define DP_LINK_STATUS_SIZE	6
 #define DP_LINK_CHECK_TIMEOUT	(10 * 1000)
 
 #define DP_LINK_CONFIGURATION_SIZE	9