[v3,5/9] vfs: Copy shouldn't forbid ranges inside the same file
diff mbox

Message ID 1443214096-12769-6-git-send-email-Anna.Schumaker@Netapp.com
State New
Headers show

Commit Message

Anna Schumaker Sept. 25, 2015, 8:48 p.m. UTC
This is perfectly valid for BTRFS and XFS, so let's leave this up to
filesystems to check.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Reviewed-by: David Sterba <dsterba@suse.com>
---
 fs/read_write.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Darrick J. Wong Sept. 28, 2015, 6:46 p.m. UTC | #1
On Fri, Sep 25, 2015 at 04:48:11PM -0400, Anna Schumaker wrote:
> This is perfectly valid for BTRFS and XFS, so let's leave this up to
> filesystems to check.
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> Reviewed-by: David Sterba <dsterba@suse.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/read_write.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index f3d6c48..8e7cb33 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -1371,10 +1371,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
>  	    file_in->f_path.mnt != file_out->f_path.mnt)
>  		return -EXDEV;
>  
> -	/* forbid ranges in the same file */
> -	if (inode_in == inode_out)
> -		return -EINVAL;
> -
>  	if (len == 0)
>  		return 0;
>  
> -- 
> 2.5.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/fs/read_write.c b/fs/read_write.c
index f3d6c48..8e7cb33 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1371,10 +1371,6 @@  ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
 	    file_in->f_path.mnt != file_out->f_path.mnt)
 		return -EXDEV;
 
-	/* forbid ranges in the same file */
-	if (inode_in == inode_out)
-		return -EINVAL;
-
 	if (len == 0)
 		return 0;