| Message ID | 1443517859-30376-14-git-send-email-tomeu.vizoso@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 29, 2015 at 11:10:51AM +0200, Tomeu Vizoso wrote: > When looking up a phy through its OF node, probe it if it hasn't > already. > > The goal is to reduce deferred probes to a minimum, as it makes it very > cumbersome to find out why a device failed to probe, and can introduce > very big delays in when a critical device is probed. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> > --- > > > drivers/usb/phy/phy.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c > index 98f75d2842b7..fb0b650bb494 100644 > --- a/drivers/usb/phy/phy.c > +++ b/drivers/usb/phy/phy.c > @@ -15,6 +15,7 @@ > #include <linux/module.h> > #include <linux/slab.h> > #include <linux/of.h> > +#include <linux/of_device.h> > > #include <linux/usb/phy.h> > > @@ -196,6 +197,8 @@ struct usb_phy *devm_usb_get_phy_by_node(struct device *dev, > goto err0; > } > > + of_device_probe(node); Ugh, this "sprinkling" of calls all over different subsystems like this isn't ok. Why is of just so broken that it has to do crap like this? I really don't like this solution / series at all, sorry. We have deferred probing, if you need stuff like that (where the dependancy tree isn't in order), how slow is that really? What is taking your hardware so long to init that warrents this being spread all across the tree? thanks, greg k-h
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 98f75d2842b7..fb0b650bb494 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -15,6 +15,7 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/usb/phy.h> @@ -196,6 +197,8 @@ struct usb_phy *devm_usb_get_phy_by_node(struct device *dev, goto err0; } + of_device_probe(node); + spin_lock_irqsave(&phy_lock, flags); phy = __of_usb_find_phy(node);
When looking up a phy through its OF node, probe it if it hasn't already. The goal is to reduce deferred probes to a minimum, as it makes it very cumbersome to find out why a device failed to probe, and can introduce very big delays in when a critical device is probed. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- drivers/usb/phy/phy.c | 3 +++ 1 file changed, 3 insertions(+)