[2/3] of: add URT UMSH-8596MD-xT panel DT bindings
diff mbox

Message ID 56158803.9000300@maciej.szmigiero.name
State New
Headers show

Commit Message

Maciej S. Szmigiero Oct. 7, 2015, 9 p.m. UTC
This patch adds DT bindings for United Radiant Technology
UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.

Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
---
 Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt

Comments

Thierry Reding Oct. 8, 2015, 8:27 a.m. UTC | #1
On Wed, Oct 07, 2015 at 11:00:51PM +0200, Maciej S. Szmigiero wrote:
> This patch adds DT bindings for United Radiant Technology
> UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
> 
> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
> ---
>  Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
> 
> diff --git a/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
> new file mode 100644
> index 0000000..57c5fa4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
> @@ -0,0 +1,12 @@
> +United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel
> +
> +Supported are LVDS versions (-11T, -19T) and parallel ones
> +(-T, -1T, -7T, -20T).
> +
> +Required properties:
> +- compatible: should be one of:
> +  "urt,umsh-8596md-t", "urt,umsh-8596md-1t", "urt,umsh-8596md-7t",
> +  "urt,umsh-8596md-11t", "urt,umsh-8596md-19t" or "urt,umsh-8596md-20t".

I'd probably list each of these on a single line for slightly more
clarity, but no need to respin because of that.

Rob, I remember there was some discussion a while back on whether or not
there should be a standard way of describing lists of compatible values,
do you know if anything was ever concluded on that topic?

Thierry
Rob Herring Oct. 13, 2015, 1:30 p.m. UTC | #2
On Thu, Oct 8, 2015 at 3:27 AM, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Oct 07, 2015 at 11:00:51PM +0200, Maciej S. Szmigiero wrote:
>> This patch adds DT bindings for United Radiant Technology
>> UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
>>
>> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
>> ---
>>  Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>>
>> diff --git a/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>> new file mode 100644
>> index 0000000..57c5fa4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>> @@ -0,0 +1,12 @@
>> +United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel
>> +
>> +Supported are LVDS versions (-11T, -19T) and parallel ones
>> +(-T, -1T, -7T, -20T).
>> +
>> +Required properties:
>> +- compatible: should be one of:
>> +  "urt,umsh-8596md-t", "urt,umsh-8596md-1t", "urt,umsh-8596md-7t",
>> +  "urt,umsh-8596md-11t", "urt,umsh-8596md-19t" or "urt,umsh-8596md-20t".
>
> I'd probably list each of these on a single line for slightly more
> clarity, but no need to respin because of that.
>
> Rob, I remember there was some discussion a while back on whether or not
> there should be a standard way of describing lists of compatible values,
> do you know if anything was ever concluded on that topic?

We're working to move the documentation to YAML and describe
constraints like this with logic expressions, but we haven't settled
on anything yet. This case will probably be just one string per line.

Rob

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
new file mode 100644
index 0000000..57c5fa4
--- /dev/null
+++ b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
@@ -0,0 +1,12 @@ 
+United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel
+
+Supported are LVDS versions (-11T, -19T) and parallel ones
+(-T, -1T, -7T, -20T).
+
+Required properties:
+- compatible: should be one of:
+  "urt,umsh-8596md-t", "urt,umsh-8596md-1t", "urt,umsh-8596md-7t",
+  "urt,umsh-8596md-11t", "urt,umsh-8596md-19t" or "urt,umsh-8596md-20t".
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.