From patchwork Thu Oct 15 07:36:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7403481 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2B21DBEEA4 for ; Thu, 15 Oct 2015 07:34:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4ECDD207E1 for ; Thu, 15 Oct 2015 07:34:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3F20020785 for ; Thu, 15 Oct 2015 07:34:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C46A7A0C5; Thu, 15 Oct 2015 00:34:04 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 370B97A098 for ; Thu, 15 Oct 2015 00:34:03 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so15375469wic.1 for ; Thu, 15 Oct 2015 00:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wNfb/avvhOiYO9E1Tr6MyX7ArU+chfZvo4ZV1x1qXwo=; b=adNM9MupH5QoFcD5scRLcv+hnkMOIpcAboj9HuAqfbI0USkblkJWhN5Wx2sABGGkyl wUOysHZhBuEx+OzMgFfQjCFwHdcWTgqSYjlwcfYKQb3OwNtDY8o1pg98XZl2Squ3xlns 0mZmEjmbdaKyVv+f5Aqpl6gePaNBjTgNX2/Dg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wNfb/avvhOiYO9E1Tr6MyX7ArU+chfZvo4ZV1x1qXwo=; b=UiDBZXwglfQ3A5GaHnc1V/A7zn6D2cq+1BGpkGR/S/y/KcmB6GyNeIw8DkDbCLJJPz Ps0apk/WbKdfjoMSm+/5wHjcH50W7d+CCjfV4oDogC7AT42EGD/K3HnxxqjDZMWL1ipi kgacYu05iKcUvEDt3uGhiyhFCoSJFBvquwQ9HTE7jU9s1yqjuqqIWbIwi/bvC/FgUFrp OTDoxp3gjslJcwNrqgfYn0dqsqdjlaorRcy6qHeRmVVuOnJaCFk3N6W5GdRYvh/Kw/5q u9rdD+mBtMuBhfu7r+0XwBY2JsWlpMGr4LuS9LCNX1k0W/7iUOWBh8xZ3hgusjQ/icox Nx5w== X-Gm-Message-State: ALoCoQljrRVWipmGLtg6utF+Le9qXhHR7RdNvOtWAYMqIZy1WQtwC9Z3pNcIiFInK8litYKfbZtF X-Received: by 10.194.61.70 with SMTP id n6mr8527462wjr.81.1444894441887; Thu, 15 Oct 2015 00:34:01 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id z4sm10201014wjz.29.2015.10.15.00.34.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Oct 2015 00:34:01 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 12/25] drm/gma500: Use correct unref in the gem bo create function Date: Thu, 15 Oct 2015 09:36:28 +0200 Message-Id: <1444894601-5200-13-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> References: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is called without dev->struct_mutex held, we need to use the _unlocked variant. Never caught in the wild since you'd need an evil userspace which races a gem_close ioctl call with the in-progress open. Signed-off-by: Daniel Vetter Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index c707fa6fca85..e3bdc8b1c32c 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -130,7 +130,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size, return ret; } /* We have the initial and handle reference but need only one now */ - drm_gem_object_unreference(&r->gem); + drm_gem_object_unreference_unlocked(&r->gem); *handlep = handle; return 0; }