From patchwork Thu Oct 15 07:36:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7403551 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6C2A9BEEA4 for ; Thu, 15 Oct 2015 07:34:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A72B820786 for ; Thu, 15 Oct 2015 07:34:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DB78420785 for ; Thu, 15 Oct 2015 07:34:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD31A7A10C; Thu, 15 Oct 2015 00:34:12 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93D8C7A0E8 for ; Thu, 15 Oct 2015 00:34:11 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so15380400wic.1 for ; Thu, 15 Oct 2015 00:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fwFswvmJAL6d6UDWYqCXp9XfX0uuDvRWBp0JoNjuy/Q=; b=Mj9NalCXs2s6ZL8MPlFci7Q13Q3s1Utf0IqMVsfsUcQ1yCOSv30Sv9FVtbBcsEtR78 Eobv7UfEyEf1J04hplrCuPG2nXorP3uL5Ae25bLWGgbvo1tiJptGHo0YoC1VJpD8cB39 u3irL1dbvD3au+mB1d5prWWzNg9KZ9am1EJlw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fwFswvmJAL6d6UDWYqCXp9XfX0uuDvRWBp0JoNjuy/Q=; b=mEDmb+xmRO4WHO3yMfUUT4UcKIDwHzfjfy9EYUQjsHwQNTijP3QiryG9FjpgA7y5bM 6z5QDIoD5ogzLHhiTlVbPCeEO6/l/aDgAr4kDJLT1QddO00UFK7TlHQvamETYVW1PL0T jrfSyAmhYa9KAwiifmQJoc30rn0czEK7Yj+4F0yb3W/mmjhtWv4MQD52cH9vab/fdW0h KX6W6pHcBbrX0ej2blPbz+JtyT4OLuj0YDjyWbMysh/5SYVPRGkC9ls25240Ulrm4tI2 yjDrMCXGzivMuVKeh9JrFgW9ASl71IUIufDy/L3B2CjX/tsvk0zqiyZk1uGL4Jemnrlg i0Tg== X-Gm-Message-State: ALoCoQn7Qyid2iHaHo/lTezzLaZZxCu6gNwq4845vIBMZJ1f8RDmFQLTMj7Qz+oDrm6Uw+FC6A0L X-Received: by 10.194.206.38 with SMTP id ll6mr8760017wjc.116.1444894450270; Thu, 15 Oct 2015 00:34:10 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id z4sm10201014wjz.29.2015.10.15.00.34.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Oct 2015 00:34:09 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 20/25] drm/exynos: drop struct_mutex from exynos_gem_map_sgt_with_dma Date: Thu, 15 Oct 2015 09:36:36 +0200 Message-Id: <1444894601-5200-21-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> References: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The sg table isn't refcounted, there's no corresponding locking for unmapping and drm_map_sg is ok with being called concurrently. So drop the locking since it doesn't protect anything. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index f6c7bc3a7e68..cf34c7f9ed93 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -367,16 +367,12 @@ int exynos_gem_map_sgt_with_dma(struct drm_device *drm_dev, { int nents; - mutex_lock(&drm_dev->struct_mutex); - nents = dma_map_sg(drm_dev->dev, sgt->sgl, sgt->nents, dir); if (!nents) { DRM_ERROR("failed to map sgl with dma.\n"); - mutex_unlock(&drm_dev->struct_mutex); return nents; } - mutex_unlock(&drm_dev->struct_mutex); return 0; }