| Message ID | 1445175573-11784-9-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/18/2015 04:39 PM, Lars-Peter Clausen wrote: > Use the new snd_pcm_hw_constraint_single() helper function instead of > calling snd_pcm_hw_constraint_minmax() with the same value for min and max > to install a constraint that limits the possible configuration values to a > single value. Using snd_pcm_hw_constraint_single() makes the indented > result clearer and is slightly shorter. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > sound/soc/codecs/twl4030.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c > index 2713e18..a5a4e9f 100644 > --- a/sound/soc/codecs/twl4030.c > +++ b/sound/soc/codecs/twl4030.c > @@ -1612,19 +1612,16 @@ static void twl4030_constraints(struct twl4030_priv *twl4030, > return; > > /* Set the constraints according to the already configured stream */ > - snd_pcm_hw_constraint_minmax(slv_substream->runtime, > + snd_pcm_hw_constraint_single(slv_substream->runtime, > SNDRV_PCM_HW_PARAM_RATE, > - twl4030->rate, > twl4030->rate); > > - snd_pcm_hw_constraint_minmax(slv_substream->runtime, > + snd_pcm_hw_constraint_single(slv_substream->runtime, > SNDRV_PCM_HW_PARAM_SAMPLE_BITS, > - twl4030->sample_bits, > twl4030->sample_bits); > > - snd_pcm_hw_constraint_minmax(slv_substream->runtime, > + snd_pcm_hw_constraint_single(slv_substream->runtime, > SNDRV_PCM_HW_PARAM_CHANNELS, > - twl4030->channels, > twl4030->channels); > } > > @@ -1669,9 +1666,9 @@ static int twl4030_startup(struct snd_pcm_substream *substream, > /* In option2 4 channel is not supported, set the > * constraint for the first stream for channels, the > * second stream will 'inherit' this cosntraint */ > - snd_pcm_hw_constraint_minmax(substream->runtime, > + snd_pcm_hw_constraint_single(substream->runtime, > SNDRV_PCM_HW_PARAM_CHANNELS, > - 2, 2); > + 2); > } > twl4030->master_substream = substream; > } >
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 2713e18..a5a4e9f 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -1612,19 +1612,16 @@ static void twl4030_constraints(struct twl4030_priv *twl4030, return; /* Set the constraints according to the already configured stream */ - snd_pcm_hw_constraint_minmax(slv_substream->runtime, + snd_pcm_hw_constraint_single(slv_substream->runtime, SNDRV_PCM_HW_PARAM_RATE, - twl4030->rate, twl4030->rate); - snd_pcm_hw_constraint_minmax(slv_substream->runtime, + snd_pcm_hw_constraint_single(slv_substream->runtime, SNDRV_PCM_HW_PARAM_SAMPLE_BITS, - twl4030->sample_bits, twl4030->sample_bits); - snd_pcm_hw_constraint_minmax(slv_substream->runtime, + snd_pcm_hw_constraint_single(slv_substream->runtime, SNDRV_PCM_HW_PARAM_CHANNELS, - twl4030->channels, twl4030->channels); } @@ -1669,9 +1666,9 @@ static int twl4030_startup(struct snd_pcm_substream *substream, /* In option2 4 channel is not supported, set the * constraint for the first stream for channels, the * second stream will 'inherit' this cosntraint */ - snd_pcm_hw_constraint_minmax(substream->runtime, + snd_pcm_hw_constraint_single(substream->runtime, SNDRV_PCM_HW_PARAM_CHANNELS, - 2, 2); + 2); } twl4030->master_substream = substream; }
Use the new snd_pcm_hw_constraint_single() helper function instead of calling snd_pcm_hw_constraint_minmax() with the same value for min and max to install a constraint that limits the possible configuration values to a single value. Using snd_pcm_hw_constraint_single() makes the indented result clearer and is slightly shorter. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/codecs/twl4030.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)