| Message ID | 1445395380-5365-3-git-send-email-wxt@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Caesar, On Tue, Oct 20, 2015 at 7:43 PM, Caesar Wang <wxt@rock-chips.com> wrote: > We need the OTP pin is gpio state before resetting the TSADC controller, > since the tshut polarity will generate a high signal. It might or might not be "high" depending on polarity, right? It's just possible that it could glitch during probe. Other than that nit, this seems fine to me. If it's not too much trouble it'd be nice if you could spin with the description change. Otherwise: Reviewed-by: Douglas Anderson <dianders@chromium.org>
Caesar, On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote: > I think the description is right, maybe need other decriptions. > The tshut polarity is low in a short period of time when the TSADC > controller is reset. > > In other words, > > If T < (setting temperature), the OTP output the High Signal. ------> if the > otp out polarity is high, the TSHUT will work. > If T > (setting temperature), the OTP output the Low Signal. Ah! I re-read the cover letter more carefully and now I see. OK, I think your current description is fine, then. ;) -Doug
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 906e938..6ea89aa 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -447,8 +447,9 @@ clock-names = "tsadc", "apb_pclk"; resets = <&cru SRST_TSADC>; reset-names = "tsadc-apb"; - pinctrl-names = "default"; - pinctrl-0 = <&otp_out>; + pinctrl-names = "init", "default"; + pinctrl-0 = <&otp_gpio>; + pinctrl-1 = <&otp_out>; #thermal-sensor-cells = <1>; rockchip,hw-tshut-temp = <95000>; status = "disabled"; @@ -1273,6 +1274,10 @@ }; tsadc { + otp_gpio: otp-gpio { + rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>; + }; + otp_out: otp-out { rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>; };
We need the OTP pin is gpio state before resetting the TSADC controller, since the tshut polarity will generate a high signal. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: - As the Doug comments, drop the thermal driver patchs since we can with pinctrl changing to work. - As the Doug's patch to add the 'init' property. arch/arm/boot/dts/rk3288.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)