| Message ID | 20151022195346.GD24439@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Thanks for pointing out. I will pick this patch at my repository. Best Regards, Jaehoon Chung On 10/23/2015 04:53 AM, Dan Carpenter wrote: > The "host->dms->ch" pointer is NULL here so we can't use it to print the > error message. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 6e600e8..f877b2c 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -752,9 +752,7 @@ static int dw_mci_edmac_init(struct dw_mci *host) > > host->dms->ch = dma_request_slave_channel(host->dev, "rx-tx"); > if (!host->dms->ch) { > - dev_err(host->dev, > - "Failed to get external DMA channel %d\n", > - host->dms->ch->chan_id); > + dev_err(host->dev, "Failed to get external DMA channel.\n"); > kfree(host->dms); > host->dms = NULL; > return -ENXIO; > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 6e600e8..f877b2c 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -752,9 +752,7 @@ static int dw_mci_edmac_init(struct dw_mci *host) host->dms->ch = dma_request_slave_channel(host->dev, "rx-tx"); if (!host->dms->ch) { - dev_err(host->dev, - "Failed to get external DMA channel %d\n", - host->dms->ch->chan_id); + dev_err(host->dev, "Failed to get external DMA channel.\n"); kfree(host->dms); host->dms = NULL; return -ENXIO;
The "host->dms->ch" pointer is NULL here so we can't use it to print the error message. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html