Patchwork HID: wacom: fix Intuos wireless report id issue

login
register
mail settings
Submitter Ping Cheng
Date Oct. 26, 2015, 9:29 p.m.
Message ID <1445894952-3495-1-git-send-email-pingc@wacom.com>
Download mbox | patch
Permalink /patch/7492081/
State New
Delegated to: Jiri Kosina
Headers show

Comments

Ping Cheng - Oct. 26, 2015, 9:29 p.m.
Intuos Pen in wireless mode does not have the same report id (2) as
when it is in USB mode (17).

This patch also moves WIRELESS next to REMOTE in type enum so we
can group devices with similar features easily.

Reported-by: Dale Brewe <dlbrewe@hotmail.com>
Tested-by: Dale Brewe <dlbrewe@hotmail.com>
Signed-off-by: Ping Cheng <pingc@wacom.com>
---
 drivers/hid/wacom_sys.c | 2 +-
 drivers/hid/wacom_wac.c | 1 -
 drivers/hid/wacom_wac.h | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)
Jiri Kosina - Nov. 2, 2015, 4:41 p.m.
On Mon, 26 Oct 2015, Ping Cheng wrote:

> Intuos Pen in wireless mode does not have the same report id (2) as
> when it is in USB mode (17).
> 
> This patch also moves WIRELESS next to REMOTE in type enum so we
> can group devices with similar features easily.
> 
> Reported-by: Dale Brewe <dlbrewe@hotmail.com>
> Tested-by: Dale Brewe <dlbrewe@hotmail.com>
> Signed-off-by: Ping Cheng <pingc@wacom.com>

Applied to hid.git#for-4.4/wacom.

Thanks,

Patch

diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 125e9d5..b4de325 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -432,7 +432,7 @@  static int wacom_query_tablet_data(struct hid_device *hdev,
 			return wacom_set_device_mode(hdev, 2, 2, 2);
 		}
 	} else if (features->device_type & WACOM_DEVICETYPE_PEN) {
-		if (features->type <= BAMBOO_PT && features->type != WIRELESS) {
+		if (features->type <= BAMBOO_PT) {
 			return wacom_set_device_mode(hdev, 2, 2, 2);
 		}
 	}
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 7b37848..453da6d 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2066,7 +2066,6 @@  static int wacom_bpt_irq(struct wacom_wac *wacom, size_t len)
 	struct wacom_features *features = &wacom->features;
 
 	if ((features->type == INTUOSHT2) &&
-	    (wacom->data[0] == WACOM_REPORT_INTUOS_PEN) &&
 	    (features->device_type & WACOM_DEVICETYPE_PEN))
 		return wacom_intuos_irq(wacom);
 	else if (len == WACOM_PKGLEN_BBTOUCH)
diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
index 95ee92b..d9e9515 100644
--- a/drivers/hid/wacom_wac.h
+++ b/drivers/hid/wacom_wac.h
@@ -129,7 +129,6 @@  enum {
 	WACOM_BEE,
 	WACOM_13HD,
 	WACOM_MO,
-	WIRELESS,
 	BAMBOO_PEN,
 	INTUOSHT,
 	INTUOSHT2,
@@ -138,6 +137,7 @@  enum {
 	WACOM_24HDT,
 	WACOM_27QHDT,
 	BAMBOO_PAD,
+	WIRELESS,
 	REMOTE,
 	TABLETPC,   /* add new TPC below */
 	TABLETPCE,