From patchwork Tue May 3 15:14:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 750412 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p43FED2Y017778 for ; Tue, 3 May 2011 15:14:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207Ab1ECPOM (ORCPT ); Tue, 3 May 2011 11:14:12 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:63756 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab1ECPOL (ORCPT ); Tue, 3 May 2011 11:14:11 -0400 Received: by vws1 with SMTP id 1so136627vws.19 for ; Tue, 03 May 2011 08:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=iORtXlYlrTaTix4/L0/vy7hv0CO0slpzjqksSp4pATc=; b=BtC9F90M0VDfm2MbclSkdxr9QF4+oZ/kcx/0qCeDvCIaZFddEe6yYySiNc9NC/NfNF 8g4bb6yTxikuv495JDvLbgZrCsQhvoLUANgNrSWM+8tGvyCA2KZhff/NLnScJUCy0mdM 3otbm1qM/OZesnIet6KX8gkRRj8++A3HUpPnM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=YPwEAK7xexUe28OZBwl0HBfDdBnOfmlSRakH4kGmcgM5b+ctrewitM3F4KfhDSrwH0 XQG5W+1o3HWVzm/HARpZm+3m5ELsfk4RS8NDte0NIx5UlZOFvXHA1rZN2hAnljUxN/GT sd2wOCHYR1FaW4vO5sK6LnzPEFTdI6ImEHr10= MIME-Version: 1.0 Received: by 10.52.0.69 with SMTP id 5mr9693418vdc.96.1304435650119; Tue, 03 May 2011 08:14:10 -0700 (PDT) Received: by 10.52.106.193 with HTTP; Tue, 3 May 2011 08:14:10 -0700 (PDT) In-Reply-To: <20110302101512.GC16181@sortiz-mobl> References: <1298986926-31180-1-git-send-email-j-keerthy@ti.com> <20110302101512.GC16181@sortiz-mobl> Date: Tue, 3 May 2011 08:14:10 -0700 Message-ID: Subject: Re: [PATCH 0/2 v5] twl4030-madc driver From: Steve Sakoman To: Keerthy Cc: lm-sensors@lm-sensors.org, guenter.roeck@ericsson.com, mikko.k.ylinen@nokia.com, amit.kucheria@canonical.com, linux-omap@vger.kernel.org, Samuel Ortiz Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 03 May 2011 15:14:13 +0000 (UTC) On Wed, Mar 2, 2011 at 2:15 AM, Samuel Ortiz wrote: > Hi Keerthy, > > On Tue, Mar 01, 2011 at 07:12:06PM +0530, Keerthy wrote: >> MADC(Monitoring ADC) driver enables monitoring analog signals using >> analog-to-digital conversion (ADC) on the input source. >> The previous discussion concluded in keeping the generic ADC >> functionality and the hwmon separate. The discussion can be found here: >> >> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg41805.html > Thanks a lot, I applied those 2 patches. I'm attempting to use this drive on the Overo platform with 2.6.39-rc5. Other than enabling the module with CONFIG_SENSORS_TWL4030_MADC=m are there any board file modifications required other than the below? I have setup the platform data for the twl4030 madc driver: However, I am not seeing the sysfs entry created: # modprobe twl4030-madc-hwmon twl4030_madc_hwmon_init entry # lsmod Module Size Used by twl4030_madc_hwmon 2594 0 ipv6 224256 16 libertas_sdio 14867 0 libertas 92429 1 libertas_sdio cfg80211 144256 1 libertas lib80211 5027 1 libertas firmware_class 5859 2 libertas_sdio,libertas # ls /sys/class/hwmon/ # I added a couple of printk's to the driver at the entry points of init and probe, and as you can see above the init message is printed, but not the probe. Am I missing something really obvious here? Steve --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 112dfc9..05dd3eb 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -637,10 +637,15 @@ static struct twl4030_codec_data overo_codec_data = { .audio = &overo_audio_data, }; +static struct twl4030_madc_platform_data overo_madc_data = { + .irq_line = 1, +}; + static struct twl4030_platform_data overo_twldata = { .irq_base = TWL4030_IRQ_BASE, .irq_end = TWL4030_IRQ_END, .gpio = &overo_gpio_data, + .madc = &overo_madc_data, .usb = &overo_usb_data, .codec = &overo_codec_data, .vmmc1 = &overo_vmmc1,