From patchwork Tue Nov 3 10:47:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 7541601 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 528BE9F4F5 for ; Tue, 3 Nov 2015 10:47:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6806F205FA for ; Tue, 3 Nov 2015 10:47:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 82E672063C for ; Tue, 3 Nov 2015 10:47:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A9A68720D0; Tue, 3 Nov 2015 02:47:25 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E6466E129 for ; Tue, 3 Nov 2015 02:47:19 -0800 (PST) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NX802YE9JAQLE40@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 03 Nov 2015 19:47:14 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.116]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 71.10.05342.2B098365; Tue, 3 Nov 2015 19:47:14 +0900 (KST) X-AuditID: cbfee690-f794e6d0000014de-97-563890b29952 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id C6.3D.23663.2B098365; Tue, 3 Nov 2015 19:47:14 +0900 (KST) Received: from localhost.localdomain ([10.252.83.67]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NX800N1DJAN2C90@mmp1.samsung.com>; Tue, 03 Nov 2015 19:47:14 +0900 (KST) From: Inki Dae To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 6/7] drm/exynos: add pm_runtime to DECON 5433 Date: Tue, 03 Nov 2015 19:47:08 +0900 Message-id: <1446547629-12521-7-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1446547629-12521-1-git-send-email-inki.dae@samsung.com> References: <1446547629-12521-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsWyRsSkRHfTBIswgwlvlS16z51ksrjy9T2b xafVrewWk+5PYLGYcX4fkwOrx9/n11k8tn97wOpxv/s4k0ffllWMHp83yQWwRnHZpKTmZJal FunbJXBl3Gr9ylzQIlnRs/sCWwPjCZEuRk4OCQETiT/rNzJD2GISF+6tZ+ti5OIQEljBKLHh /E6WLkYOsKLzu6HiSxkluq7MZ4FwvjNKfGiYxATSzSagKjFxxX02EFtEQFni78RVjCA2s0A/ o8SP8wogg4QFHCT+veUBCbMAlf87uRCsnFfAReLvjwWMEEfISZw8NpkVxOYUcJVYc3oFI0ir EFDNvfVGIGslBLrZJVqP72eBmCMg8W3yIag7ZSU2HYD6RVLi4IobLBMYhRcwMqxiFE0tSC4o TkovMtErTswtLs1L10vOz93ECAzn0/+eTdjBeO+A9SFGAQ5GJR7eH8vMw4RYE8uKK3MPMZoC bZjILCWanA+MmrySeENjMyMLUxNTYyNzSzMlcd7XUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEy cXBKNTDWRd2f5dKw/mhEY1VkRc8DpY21ylMi35+4Y+t/bHqsO3vBaVGVzrDTuaGHnresmrrm ngNz49z44q7YQ4wTFhSvvuj7tnBP2zd2/pLb/r6OK83b6nZc2XCv2chjvdu57e0uE5NXWV4U MP5vrpX07GmOUkaxVtq3vKJVHFvMnay4HrTxeUf8yFBiKc5INNRiLipOBACITdpDYgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jAd1NEyzCDH6ekbHoPXeSyeLK1/ds Fp9Wt7JbTLo/gcVixvl9TA6sHn+fX2fx2P7tAavH/e7jTB59W1YxenzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmHGr9StzQYtkRc/uC2wNjCdEuhg5OCQETCTO 72brYuQEMsUkLtxbD2RzcQgJLGWU6LoynwXC+c4o8aFhEhNIFZuAqsTEFffBOkQElCX+TlzF CGIzC/QzSvw4rwAyVFjAQeLfWx6QMAtQ+b+TC8HKeQVcJP7+WMAIsUxO4uSxyawgNqeAq8Sa 0ysYQVqFgGrurTeawMi7gJFhFaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwzDyT2sF4 cJf7IUYBDkYlHt4FS8zDhFgTy4orcw8xSnAwK4nwTu6xCBPiTUmsrEotyo8vKs1JLT7EaAp0 10RmKdHkfGA855XEGxqbmBlZGpkbWhgZmyuJ8+p7GoUJCaQnlqRmp6YWpBbB9DFxcEo1MCZv /HLSpTb+UXmv1Qe75Ev+j0QdOVpZp7MmfJL7l1e1u/LlpObgx6WKXfYLl8tcOabMoGu/PnPn j12SxaE/mV1DmfZ9ChJvPMpinXr4gk3PlquHrmt6yNiouDLl77s0R25h36eI+nj96Q3Xk9uv e1gfEwjrPnG3dy7jTTWWHUfmar1btSxphxJLcUaioRZzUXEiABlx8YGvAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: linux-samsung-soc@vger.kernel.org, Gustavo Padovan X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Changelog v2: - Change CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 54 +++++++++++++++++++-------- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index fbe1b31..edfd6e3 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -385,12 +385,6 @@ static void decon_enable(struct exynos_drm_crtc *crtc) pm_runtime_get_sync(ctx->dev); - for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++) { - ret = clk_prepare_enable(ctx->clks[i]); - if (ret < 0) - goto err; - } - set_bit(BIT_CLKS_ENABLED, &ctx->flags); /* if vblank was enabled status, enable it again. */ @@ -399,11 +393,6 @@ static void decon_enable(struct exynos_drm_crtc *crtc) decon_commit(ctx->crtc); - return; -err: - while (--i >= 0) - clk_disable_unprepare(ctx->clks[i]); - set_bit(BIT_SUSPENDED, &ctx->flags); } @@ -425,9 +414,6 @@ static void decon_disable(struct exynos_drm_crtc *crtc) decon_swreset(ctx); - for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++) - clk_disable_unprepare(ctx->clks[i]); - clear_bit(BIT_CLKS_ENABLED, &ctx->flags); pm_runtime_put_sync(ctx->dev); @@ -478,7 +464,6 @@ err: static struct exynos_drm_crtc_ops decon_crtc_ops = { .enable = decon_enable, .disable = decon_disable, - .commit = decon_commit, .enable_vblank = decon_enable_vblank, .disable_vblank = decon_disable_vblank, .atomic_begin = decon_atomic_begin, @@ -581,6 +566,44 @@ out: return IRQ_HANDLED; } +#ifdef CONFIG_PM +static int exynos5433_decon_suspend(struct device *dev) +{ + struct decon_context *ctx = dev_get_drvdata(dev); + int i; + + for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++) + clk_disable_unprepare(ctx->clks[i]); + + return 0; +} + +static int exynos5433_decon_resume(struct device *dev) +{ + struct decon_context *ctx = dev_get_drvdata(dev); + int i, ret; + + for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++) { + ret = clk_prepare_enable(ctx->clks[i]); + if (ret < 0) + goto err; + } + + return 0; + +err: + while (--i >= 0) + clk_disable_unprepare(ctx->clks[i]); + + return ret; +} +#endif + +static const struct dev_pm_ops exynos5433_decon_pm_ops = { + SET_RUNTIME_PM_OPS(exynos5433_decon_suspend, exynos5433_decon_resume, + NULL) +}; + static const struct of_device_id exynos5433_decon_driver_dt_match[] = { { .compatible = "samsung,exynos5433-decon", @@ -684,6 +707,7 @@ struct platform_driver exynos5433_decon_driver = { .remove = exynos5433_decon_remove, .driver = { .name = "exynos5433-decon", + .pm = &exynos5433_decon_pm_ops, .of_match_table = exynos5433_decon_driver_dt_match, }, };