diff mbox

thermal: rockchip: fix compile error

Message ID 1446990043-8096-1-git-send-email-wxt@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Caesar Wang Nov. 8, 2015, 1:40 p.m. UTC
Missing a include file caused compile error.

drivers/thermal/rockchip_thermal.c:
In function 'rockchip_thermal_suspend':
drivers/thermal/rockchip_thermal.c:720:2: error: implicit
declaration of function 'pinctrl_pm_select_sleep_state'
[-Werror=implicit-function-declaration]
pinctrl_pm_select_sleep_state(dev);
                 ^
drivers/thermal/rockchip_thermal.c:
In function 'rockchip_thermal_resume':
drivers/thermal/rockchip_thermal.c:759:2: error: implicit
declaration of function 'pinctrl_pm_select_default_state'
[-Werror=implicit-function-declaration]
^pinctrl_pm_select_default_state(dev);
cc1: some warnings being treated as errors

Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state
to avoid glitches")

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

 drivers/thermal/rockchip_thermal.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eduardo Valentin Nov. 9, 2015, 7:36 p.m. UTC | #1
On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote:
> Missing a include file caused compile error.
> 
> drivers/thermal/rockchip_thermal.c:
> In function 'rockchip_thermal_suspend':
> drivers/thermal/rockchip_thermal.c:720:2: error: implicit
> declaration of function 'pinctrl_pm_select_sleep_state'
> [-Werror=implicit-function-declaration]
> pinctrl_pm_select_sleep_state(dev);
>                  ^
> drivers/thermal/rockchip_thermal.c:
> In function 'rockchip_thermal_resume':
> drivers/thermal/rockchip_thermal.c:759:2: error: implicit
> declaration of function 'pinctrl_pm_select_default_state'
> [-Werror=implicit-function-declaration]
> ^pinctrl_pm_select_default_state(dev);
> cc1: some warnings being treated as errors
> 
> Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state
> to avoid glitches")


Adding this to my tree and sending to ruis too.


Thanks

> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
> 
>  drivers/thermal/rockchip_thermal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index df28049..8928d67 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -25,6 +25,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/reset.h>
>  #include <linux/thermal.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  /**
>   * If the temperature over a period of time High,
> -- 
> 1.9.1
>
Stephen Rothwell Nov. 11, 2015, 10:06 p.m. UTC | #2
Hi Eduardo,

On Mon, 9 Nov 2015 11:36:39 -0800 Eduardo Valentin <edubezval@gmail.com> wrote:
>
> On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote:
> > Missing a include file caused compile error.
> > 
> > drivers/thermal/rockchip_thermal.c:
> > In function 'rockchip_thermal_suspend':
> > drivers/thermal/rockchip_thermal.c:720:2: error: implicit
> > declaration of function 'pinctrl_pm_select_sleep_state'
> > [-Werror=implicit-function-declaration]
> > pinctrl_pm_select_sleep_state(dev);
> >                  ^
> > drivers/thermal/rockchip_thermal.c:
> > In function 'rockchip_thermal_resume':
> > drivers/thermal/rockchip_thermal.c:759:2: error: implicit
> > declaration of function 'pinctrl_pm_select_default_state'
> > [-Werror=implicit-function-declaration]
> > ^pinctrl_pm_select_default_state(dev);
> > cc1: some warnings being treated as errors
> > 
> > Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state
> > to avoid glitches")  
> 
> 
> Adding this to my tree and sending to ruis too.

This missed the merge of the thermal tree into Linus' tree and so is
now needed in Linus' tree ASAP (several builds are failing).
Eduardo Valentin Nov. 12, 2015, 3:32 a.m. UTC | #3
Hello Stephen,

On Thu, Nov 12, 2015 at 09:06:58AM +1100, Stephen Rothwell wrote:
> Hi Eduardo,
> 
> On Mon, 9 Nov 2015 11:36:39 -0800 Eduardo Valentin <edubezval@gmail.com> wrote:
> >
> > On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote:
> > > Missing a include file caused compile error.
> > > 

<cut>

> > 
> > 
> > Adding this to my tree and sending to ruis too.
> 
> This missed the merge of the thermal tree into Linus' tree and so is
> now needed in Linus' tree ASAP (several builds are failing).

Sure. I will send the patch directly to Linus.

Thanks for the heads up.

> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
diff mbox

Patch

diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index df28049..8928d67 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -25,6 +25,7 @@ 
 #include <linux/platform_device.h>
 #include <linux/reset.h>
 #include <linux/thermal.h>
+#include <linux/pinctrl/consumer.h>
 
 /**
  * If the temperature over a period of time High,