From patchwork Mon Nov 9 13:50:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7584071 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BC2509F1AF for ; Mon, 9 Nov 2015 13:51:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D7ECD2061C for ; Mon, 9 Nov 2015 13:51:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE3B82047B for ; Mon, 9 Nov 2015 13:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbbKINvt (ORCPT ); Mon, 9 Nov 2015 08:51:49 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:64234 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbKINvs (ORCPT ); Mon, 9 Nov 2015 08:51:48 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0MRhYD-1ZpVSN2vEn-00SvMa; Mon, 09 Nov 2015 14:50:50 +0100 From: Arnd Bergmann To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Pali Rohar , "Andrew F. Davis" , Xiong Zhou , linux-i2c@vger.kernel.org, Dmitry Eremin-Solenikov , David Woodhouse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] power: bq27xxx_battery: Revert "Remove unneeded dependency in Kconfig" Date: Mon, 09 Nov 2015 14:50:47 +0100 Message-ID: <3819790.E2ziFviWmU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:3KMmJbBE2BMWw885NSLT1JwMi1HLJhgXqNWsEydfqnu5aXS1wcy 1o0OVGZ/PbFNJIfc75Z7h57KkxaQqsC2zwcowjwZia8wO5vzgRlR0vKrpU1sRyBJH/YNyFC X9PcXSdFViLTxGyK/01qzJyxeAT0WwqHplF5MIAjDKnpAxy/P/+eHq0/ki+BfM2Tg2k1G95 vjGeTE9szmWBFHArw1GRg== X-UI-Out-Filterresults: notjunk:1; V01:K0:oPPx4rOkxb8=:cGYRiOHWzJafbLZij1fVHr JUIdxluKplO3Nswamr+jLK+MeatT2OVUvYRKP8urn/YyjD9bMYlEU9KJHDyJrGzaMOodk1Rxv czE4sRmW+koxF5Y0FY/ZqjYQFdpy/6FvjU8tK6cmesCL6NX5IC8XLgXqu5AxS2ySlrP6Q6QPz 3whpGGSy4N6/0h1ZK4hwLWXw6HmSQ3VhzShXYCKR+b8k0O3H7uaC29iHGR0OI4Xy9OMLHogKe +pHtZNb3GcskUbQuo4ZRA7PwvxcJowtErUIY0wgx/nBG0JOeNpFQe53ckNQMw0y5hxcizMpfQ ia14VL7jwjVGsjU1ojgMoOT2gr5Y28e0ZhZizmRJKYoiCUNz/CM34ZCgg8vQhFIhvTjv5090s OBns8r2ivdlCMKNSuHY4hsTS6uTowx3oSu6waTgjI1YH1eEkin1lE5g32OTGGdwkKmDIf2Ria QWL8kYmhtwHqNcGuzd6hdPUQA31lw5nxRECVnLWpJ7VF/0c6dm2nN2TuwJDjZiUDXADWzGXGA u1Pv/DpigigTvC1qs+k1rnby9aiDMvTAFLkPxUTHB5Q4pplYDqcjD208oKihS/BEFSIr4YH7V Gs2i0Lg+P6KJJmvuzBy8Bb25QPIuqVyN9TVhFSc8vvIGzr948kp6w39d33CndifqS7pfQIGxz XmiEpi0+n73Q1o6UjVnVm1ZIQViuwDFCCsl939m1z+xg+FEYOmClZHtekTz9DCSM11QfSni99 MALlP+3k4gr60ZgX Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dependency was clearly needed, without it it is possible to build the core i2c driver as a loadable module and the bq27xxx driver built-in, which results in link errors: drivers/built-in.o: In function `bq27xxx_battery_i2c_read': binder.c:(.text+0x360bf0): undefined reference to `i2c_transfer' binder.c:(.text+0x360c10): undefined reference to `i2c_transfer' drivers/built-in.o: In function `bq27xxx_battery_init': binder.c:(.init.text+0xe668): undefined reference to `i2c_register_driver' drivers/built-in.o: In function `bq27xxx_battery_exit': binder.c:(.exit.text+0x1a0c): undefined reference to `i2c_del_driver' Signed-off-by: Arnd Bergmann Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig") --- The bug was originally found and fixed by Xiong Zhou, but Andrew Davis broke it again by reverting the fix. I found it today on my ARM randconfig builds. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 237d7aa73e8c..9f53fb74ae6f 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -159,6 +159,7 @@ config BATTERY_SBS config BATTERY_BQ27XXX tristate "BQ27xxx battery driver" + depends on I2C || I2C=n help Say Y here to enable support for batteries with BQ27xxx (I2C/HDQ) chips.