diff mbox

mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags

Message ID 1448475984-11332-1-git-send-email-saurabh.truth@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

saurabh Nov. 25, 2015, 6:26 p.m. UTC
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/mmc/host/of_mmc_spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ulf Hansson Dec. 4, 2015, 2:56 p.m. UTC | #1
On 25 November 2015 at 19:26, Saurabh Sengar <saurabh.truth@gmail.com> wrote:
> If no primary handler is specified for threaded_irq then a
> default one is assigned which always returns IRQ_WAKE_THREAD.
> This handler requires the IRQF_ONESHOT, because the source of
> interrupt is not disabled
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/of_mmc_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 6e218fb..660170c 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -55,8 +55,8 @@ static int of_mmc_spi_init(struct device *dev,
>  {
>         struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>
> -       return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> -                                   dev_name(dev), mmc);
> +       return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> +                                       IRQF_ONESHOT, dev_name(dev), mmc);
>  }
>
>  static void of_mmc_spi_exit(struct device *dev, void *mmc)
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index 6e218fb..660170c 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -55,8 +55,8 @@  static int of_mmc_spi_init(struct device *dev,
 {
 	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
 
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+					IRQF_ONESHOT, dev_name(dev), mmc);
 }
 
 static void of_mmc_spi_exit(struct device *dev, void *mmc)