| Message ID | 20151130075219.GA27737@jci-VirtualBox (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 30.11.2015 16:52, Mutharaju, Prasanna (P.) wrote: > From: Prasanna Karthik <mkarthi3@visteon.com> > > Remove unneeded variable used to store return value. > --- > v3: Modified subject and changelog comments > --- > > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com> ... and now download the patch and try to apply it with "git am". What is missing? :) Best regards, Krzysztof > --- > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c > index e9eb935..ec6fb14 100644 > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw) > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index) > { > struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw); > - int ret = 0; > > s3c2410_modify_misccr((clkout->mask << clkout->shift), > (index << clkout->shift)); > > - return ret; > + return 0; > } > > static const struct clk_ops s3c24xx_clkout_ops = { > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 30, 2015 at 07:52:22AM +0000, Mutharaju, Prasanna (P.) wrote: > From: Prasanna Karthik <mkarthi3@visteon.com> > > Remove unneeded variable used to store return value. > --- > v3: Modified subject and changelog comments > --- > > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com> Everything after the first triple-dash doesn't make it into the git history, so you are expected to write the S-o-b line above the list of things changed since a previous submission. Other than that the patch looks fine. Uwe
On Mon, Nov 30, 2015 at 09:15:43AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 30, 2015 at 07:52:22AM +0000, Mutharaju, Prasanna (P.) wrote: > > From: Prasanna Karthik <mkarthi3@visteon.com> > > > > Remove unneeded variable used to store return value. > > --- > > v3: Modified subject and changelog comments > > --- > > > > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com> > > Everything after the first triple-dash doesn't make it into the git > history, so you are expected to write the S-o-b line above the list of > things changed since a previous submission. Thanks, I resent the patch again with S-o-b before changelog. > > Other than that the patch looks fine. > > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c index e9eb935..ec6fb14 100644 --- a/drivers/clk/samsung/clk-s3c2410-dclk.c +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw) static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index) { struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw); - int ret = 0; s3c2410_modify_misccr((clkout->mask << clkout->shift), (index << clkout->shift)); - return ret; + return 0; } static const struct clk_ops s3c24xx_clkout_ops = {