From patchwork Mon Nov 30 13:38:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 7724391 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 40AC09F1C0 for ; Mon, 30 Nov 2015 13:45:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6714E20524 for ; Mon, 30 Nov 2015 13:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E5A72051D for ; Mon, 30 Nov 2015 13:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbbK3NpF (ORCPT ); Mon, 30 Nov 2015 08:45:05 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:46338 "EHLO linuxmail.bmw-carit.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753685AbbK3NpE (ORCPT ); Mon, 30 Nov 2015 08:45:04 -0500 Received: from localhost (handman.bmw-carit.intra [192.168.101.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linuxmail.bmw-carit.de (Postfix) with ESMTPS id 29097403CD; Mon, 30 Nov 2015 14:27:09 +0100 (CET) From: Daniel Wagner To: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Cc: Daniel Wagner , Thomas Gleixner , Peter Zijlstra , linux-kbuild@vger.kernel.org, Marcelo Tosatti , Paolo Bonzini , "Paul E. McKenney" , Paul Gortmaker , Steven Rostedt , Boqun Feng Subject: [PATCH tip v5 2/5] kbuild: Add option to turn incompatible pointer check into error Date: Mon, 30 Nov 2015 14:38:28 +0100 Message-Id: <1448890711-5812-3-git-send-email-daniel.wagner@bmw-carit.de> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1448890711-5812-1-git-send-email-daniel.wagner@bmw-carit.de> References: <1448890711-5812-1-git-send-email-daniel.wagner@bmw-carit.de> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With the introduction of the simple wait API we have two very similar APIs in the kernel. For example wake_up() and swake_up() is only one character away. Although the compiler will warn happily the wrong usage it keeps on going an even links the kernel. Thomas and Peter would rather like to see early missuses reported as error early on. In a first attempt we tried to wrap all swait and wait calls into a macro which has an compile time type assertion. The result was pretty ugly and wasn't able to catch all wrong usages. woken_wake_function(), autoremove_wake_function() and wake_bit_function() are assigned as function pointers. Wrapping them with a macro around is not possible. Prefixing them with '_' was also not a real option because there some users in the kernel which do use them as well. All in all this attempt looked to intrusive and too ugly. An alternative is to turn the pointer type check into an error which catches wrong type uses. Obviously not only the swait/wait ones. That isn't a bad thing either. Though for the beginning let's introduce it as options in the kernel hacking section. Signed-off-by: Daniel Wagner Cc: Thomas Gleixner Cc: Peter Zijlstra --- Makefile | 4 ++++ lib/Kconfig.debug | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/Makefile b/Makefile index 416660d..8817273 100644 --- a/Makefile +++ b/Makefile @@ -625,6 +625,10 @@ KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \ $(call cc-option,-fno-partial-inlining) endif +ifdef CONFIG_ENABLE_ERR_TYPE_CHECK +KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) +endif + ifneq ($(CONFIG_FRAME_WARN),0) KBUILD_CFLAGS += $(call cc-option,-Wframe-larger-than=${CONFIG_FRAME_WARN}) endif diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ab76b99..21c0193 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -194,6 +194,13 @@ config ENABLE_MUST_CHECK suppress the "warning: ignoring return value of 'foo', declared with attribute warn_unused_result" messages. +config ENABLE_ERR_TYPE_CHECK + bool "Turn pointer type check into an error" + default n + help + Instead of just warning that a wrong pointer type is used, + bail with a proper compile error. + config FRAME_WARN int "Warn for stack frames larger than (needs gcc 4.4)" range 0 8192