[v2,1/2] drm/exynos: dp: add of_graph dt binding support for panel
diff mbox

Message ID 1449057472-4389-1-git-send-email-inki.dae@samsung.com
State New
Headers show

Commit Message

Inki Dae Dec. 2, 2015, 11:57 a.m. UTC
This patch adds of_graph dt binding support for panel device
and also keeps the backward compatibility.

i.e.,
The dts file for Exynos5800 based peach pi board
has a panel property so we need to keep the backward compatibility.

Changelog v2:
- return -EINVAL if getting a port node failed.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

Comments

Javier Martinez Canillas Dec. 2, 2015, 3:04 p.m. UTC | #1
Hello Inki,

On 12/02/2015 08:57 AM, Inki Dae wrote:
> This patch adds of_graph dt binding support for panel device
> and also keeps the backward compatibility.
>

You have to also update the DT binding doc which seems to be
outdated already:

Documentation/devicetree/bindings/display/exynos/exynos_dp.txt

> i.e.,
> The dts file for Exynos5800 based peach pi board
> has a panel property so we need to keep the backward compatibility.
>

How did you test this patch?
 
Best regards,
Inki Dae Dec. 3, 2015, 2:11 a.m. UTC | #2
Hi Javier,

2015? 12? 03? 00:04? Javier Martinez Canillas ?(?) ? ?:
> Hello Inki,
> 
> On 12/02/2015 08:57 AM, Inki Dae wrote:
>> This patch adds of_graph dt binding support for panel device
>> and also keeps the backward compatibility.
>>
> 
> You have to also update the DT binding doc which seems to be
> outdated already:
> 
> Documentation/devicetree/bindings/display/exynos/exynos_dp.txt

Right. It should be updated.

> 
>> i.e.,
>> The dts file for Exynos5800 based peach pi board
>> has a panel property so we need to keep the backward compatibility.
>>
> 
> How did you test this patch?

I thought you will test it and give me tested-by because you commented like below,
" Assuming you can make a distinction if the endpoint is a panel or a bridge,
then yes, I agree with the idea of the patch. Please feel free to cc me if
you post such a patch and I'll gladly test it on my Exynos5800 Peach Pi."

That is why I cced you. I really have no any Exynos5800 Peach Pi board.

Thanks,
Inki Dae

>  
> Best regards,
>
Inki Dae Dec. 3, 2015, 7:11 a.m. UTC | #3
It seems that below patch should be modifed for only one of two outbound nodes - panel
and bridge - to be bound because in case of using bridge device, the bridge driver will
bind the panel. I will fix and post it again.

Thanks,
Inki Dae

2015? 12? 02? 20:57? Inki Dae ?(?) ? ?:
> This patch adds of_graph dt binding support for panel device
> and also keeps the backward compatibility.
> 
> i.e.,
> The dts file for Exynos5800 based peach pi board
> has a panel property so we need to keep the backward compatibility.
> 
> Changelog v2:
> - return -EINVAL if getting a port node failed.
> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 94f02a0..0b53045 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -1392,7 +1392,7 @@ static const struct component_ops exynos_dp_ops = {
>  static int exynos_dp_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct device_node *panel_node, *bridge_node, *endpoint;
> +	struct device_node *panel_node = NULL, *bridge_node, *endpoint = NULL;
>  	struct exynos_dp_device *dp;
>  	int ret;
>  
> @@ -1403,15 +1403,32 @@ static int exynos_dp_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, dp);
>  
> +	/* This is for the backward compatibility. */
>  	panel_node = of_parse_phandle(dev->of_node, "panel", 0);
>  	if (panel_node) {
>  		dp->panel = of_drm_find_panel(panel_node);
>  		of_node_put(panel_node);
>  		if (!dp->panel)
>  			return -EPROBE_DEFER;
> +	} else {
> +		endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> +		if (endpoint) {
> +			panel_node = of_graph_get_remote_port_parent(endpoint);
> +			if (panel_node) {
> +				dp->panel = of_drm_find_panel(panel_node);
> +				of_node_put(panel_node);
> +				if (!dp->panel)
> +					return -EPROBE_DEFER;
> +			} else {
> +				DRM_ERROR("no port node for panel device.\n");
> +				return -EINVAL;
> +			}
> +		}
>  	}
>  
> -	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> +	panel_node = !endpoint ? NULL : panel_node;
> +
> +	endpoint = of_graph_get_next_endpoint(dev->of_node, panel_node);
>  	if (endpoint) {
>  		bridge_node = of_graph_get_remote_port_parent(endpoint);
>  		if (bridge_node) {
>
Rob Herring Dec. 3, 2015, 10:51 p.m. UTC | #4
On Wed, Dec 2, 2015 at 5:57 AM, Inki Dae <inki.dae@samsung.com> wrote:
> This patch adds of_graph dt binding support for panel device
> and also keeps the backward compatibility.
>
> i.e.,
> The dts file for Exynos5800 based peach pi board
> has a panel property so we need to keep the backward compatibility.
>
> Changelog v2:
> - return -EINVAL if getting a port node failed.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 94f02a0..0b53045 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -1392,7 +1392,7 @@ static const struct component_ops exynos_dp_ops = {
>  static int exynos_dp_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *panel_node, *bridge_node, *endpoint;
> +       struct device_node *panel_node = NULL, *bridge_node, *endpoint = NULL;
>         struct exynos_dp_device *dp;
>         int ret;
>
> @@ -1403,15 +1403,32 @@ static int exynos_dp_probe(struct platform_device *pdev)
>
>         platform_set_drvdata(pdev, dp);
>
> +       /* This is for the backward compatibility. */
>         panel_node = of_parse_phandle(dev->of_node, "panel", 0);
>         if (panel_node) {
>                 dp->panel = of_drm_find_panel(panel_node);
>                 of_node_put(panel_node);
>                 if (!dp->panel)
>                         return -EPROBE_DEFER;
> +       } else {
> +               endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> +               if (endpoint) {
> +                       panel_node = of_graph_get_remote_port_parent(endpoint);
> +                       if (panel_node) {
> +                               dp->panel = of_drm_find_panel(panel_node);
> +                               of_node_put(panel_node);
> +                               if (!dp->panel)
> +                                       return -EPROBE_DEFER;
> +                       } else {
> +                               DRM_ERROR("no port node for panel device.\n");
> +                               return -EINVAL;
> +                       }
> +               }

This should be a fairly common sequence, so please make it one. Only
which port is the panel should vary.

Rob

Patch
diff mbox

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 94f02a0..0b53045 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1392,7 +1392,7 @@  static const struct component_ops exynos_dp_ops = {
 static int exynos_dp_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
-	struct device_node *panel_node, *bridge_node, *endpoint;
+	struct device_node *panel_node = NULL, *bridge_node, *endpoint = NULL;
 	struct exynos_dp_device *dp;
 	int ret;
 
@@ -1403,15 +1403,32 @@  static int exynos_dp_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, dp);
 
+	/* This is for the backward compatibility. */
 	panel_node = of_parse_phandle(dev->of_node, "panel", 0);
 	if (panel_node) {
 		dp->panel = of_drm_find_panel(panel_node);
 		of_node_put(panel_node);
 		if (!dp->panel)
 			return -EPROBE_DEFER;
+	} else {
+		endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
+		if (endpoint) {
+			panel_node = of_graph_get_remote_port_parent(endpoint);
+			if (panel_node) {
+				dp->panel = of_drm_find_panel(panel_node);
+				of_node_put(panel_node);
+				if (!dp->panel)
+					return -EPROBE_DEFER;
+			} else {
+				DRM_ERROR("no port node for panel device.\n");
+				return -EINVAL;
+			}
+		}
 	}
 
-	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
+	panel_node = !endpoint ? NULL : panel_node;
+
+	endpoint = of_graph_get_next_endpoint(dev->of_node, panel_node);
 	if (endpoint) {
 		bridge_node = of_graph_get_remote_port_parent(endpoint);
 		if (bridge_node) {