KVM: VMX: fix the writing POSTED_INTR_NV

Message ID	1449120574-29893-1-git-send-email-roy.qing.li@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <kvm-owner@kernel.org> From: roy.qing.li@gmail.com To: x86@kernel.org, kvm@vger.kernel.org, yang.z.zhang@Intel.com Subject: [PATCH] KVM: VMX: fix the writing POSTED_INTR_NV Date: Thu, 3 Dec 2015 13:29:34 +0800 Message-Id: <1449120574-29893-1-git-send-email-roy.qing.li@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk

Message ID

1449120574-29893-1-git-send-email-roy.qing.li@gmail.com (mailing list archive)

State

New, archived

Headers

From: roy.qing.li@gmail.com
To: x86@kernel.org, kvm@vger.kernel.org, yang.z.zhang@Intel.com
Subject: [PATCH] KVM: VMX: fix the writing POSTED_INTR_NV
Date: Thu,  3 Dec 2015 13:29:34 +0800
Message-Id: <1449120574-29893-1-git-send-email-roy.qing.li@gmail.com>
Sender: kvm-owner@vger.kernel.org
Precedence: bulk

Commit Message

roy.qing.li@gmail.com Dec. 3, 2015, 5:29 a.m. UTC

From: Li RongQing <roy.qing.li@gmail.com> 

POSTED_INTR_NV is 16bit, should not use 64bit write function

[ 5311.676074] vmwrite error: reg 3 value 0 (err 12)
  [ 5311.680001] CPU: 49 PID: 4240 Comm: qemu-system-i38 Tainted: G I 4.1.13-WR8.0.0.0_standard #1
  [ 5311.689343] Hardware name: Intel Corporation S2600WT2/S2600WT2, BIOS SE5C610.86B.01.01.0008.021120151325 02/11/2015
  [ 5311.699550] 00000000 00000000 e69a7e1c c1950de1 00000000 e69a7e38 fafcff45 fafebd24
  [ 5311.706924] 00000003 00000000 0000000c b6a06dfa e69a7e40 fafcff79 e69a7eb0 fafd5f57
  [ 5311.714296] e69a7ec0 c1080600 00000000 00000001 c0e18018 000001be 00000000 00000b43
  [ 5311.721651] Call Trace:
  [ 5311.722942] [<c1950de1>] dump_stack+0x4b/0x75
  [ 5311.726467] [<fafcff45>] vmwrite_error+0x35/0x40 [kvm_intel]
  [ 5311.731444] [<fafcff79>] vmcs_writel+0x29/0x30 [kvm_intel]
  [ 5311.736228] [<fafd5f57>] vmx_create_vcpu+0x337/0xb90 [kvm_intel]
  [ 5311.741600] [<c1080600>] ? dequeue_task_fair+0x2e0/0xf60
  [ 5311.746197] [<faf3b9ca>] kvm_arch_vcpu_create+0x3a/0x70 [kvm]
  [ 5311.751278] [<faf29e9d>] kvm_vm_ioctl+0x14d/0x640 [kvm]
  [ 5311.755771] [<c1129d44>] ? free_pages_prepare+0x1a4/0x2d0
  [ 5311.760455] [<c13e2842>] ? debug_smp_processor_id+0x12/0x20
  [ 5311.765333] [<c10793be>] ? sched_move_task+0xbe/0x170
  [ 5311.769621] [<c11752b3>] ? kmem_cache_free+0x213/0x230
  [ 5311.774016] [<faf29d50>] ? kvm_set_memory_region+0x60/0x60 [kvm]
  [ 5311.779379] [<c1199fa2>] do_vfs_ioctl+0x2e2/0x500
  [ 5311.783285] [<c11752b3>] ? kmem_cache_free+0x213/0x230
  [ 5311.787677] [<c104dc73>] ? __mmdrop+0x63/0xd0
  [ 5311.791196] [<c104dc73>] ? __mmdrop+0x63/0xd0
  [ 5311.794712] [<c104dc73>] ? __mmdrop+0x63/0xd0
  [ 5311.798234] [<c11a2ed7>] ? __fget+0x57/0x90
  [ 5311.801559] [<c11a2f72>] ? __fget_light+0x22/0x50
  [ 5311.805464] [<c119a240>] SyS_ioctl+0x80/0x90
  [ 5311.808885] [<c1957d30>] sysenter_do_call+0x12/0x12
  [ 5312.059280] kvm: zapping shadow pages for mmio generation wraparound
  [ 5313.678415] kvm [4231]: vcpu0 disabled perfctr wrmsr: 0xc2 data 0xffff
  [ 5313.726518] kvm [4231]: vcpu0 unhandled rdmsr: 0x570

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Cc: Yang Zhang <yang.z.zhang@Intel.com>
---
 arch/x86/kvm/vmx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paolo Bonzini Dec. 3, 2015, 1:58 p.m. UTC | #1

On 03/12/2015 06:29, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com> 
> 
> POSTED_INTR_NV is 16bit, should not use 64bit write function
> 
> [ 5311.676074] vmwrite error: reg 3 value 0 (err 12)
>   [ 5311.680001] CPU: 49 PID: 4240 Comm: qemu-system-i38 Tainted: G I 4.1.13-WR8.0.0.0_standard #1
>   [ 5311.689343] Hardware name: Intel Corporation S2600WT2/S2600WT2, BIOS SE5C610.86B.01.01.0008.021120151325 02/11/2015
>   [ 5311.699550] 00000000 00000000 e69a7e1c c1950de1 00000000 e69a7e38 fafcff45 fafebd24
>   [ 5311.706924] 00000003 00000000 0000000c b6a06dfa e69a7e40 fafcff79 e69a7eb0 fafd5f57
>   [ 5311.714296] e69a7ec0 c1080600 00000000 00000001 c0e18018 000001be 00000000 00000b43
>   [ 5311.721651] Call Trace:
>   [ 5311.722942] [<c1950de1>] dump_stack+0x4b/0x75
>   [ 5311.726467] [<fafcff45>] vmwrite_error+0x35/0x40 [kvm_intel]
>   [ 5311.731444] [<fafcff79>] vmcs_writel+0x29/0x30 [kvm_intel]
>   [ 5311.736228] [<fafd5f57>] vmx_create_vcpu+0x337/0xb90 [kvm_intel]
>   [ 5311.741600] [<c1080600>] ? dequeue_task_fair+0x2e0/0xf60
>   [ 5311.746197] [<faf3b9ca>] kvm_arch_vcpu_create+0x3a/0x70 [kvm]
>   [ 5311.751278] [<faf29e9d>] kvm_vm_ioctl+0x14d/0x640 [kvm]
>   [ 5311.755771] [<c1129d44>] ? free_pages_prepare+0x1a4/0x2d0
>   [ 5311.760455] [<c13e2842>] ? debug_smp_processor_id+0x12/0x20
>   [ 5311.765333] [<c10793be>] ? sched_move_task+0xbe/0x170
>   [ 5311.769621] [<c11752b3>] ? kmem_cache_free+0x213/0x230
>   [ 5311.774016] [<faf29d50>] ? kvm_set_memory_region+0x60/0x60 [kvm]
>   [ 5311.779379] [<c1199fa2>] do_vfs_ioctl+0x2e2/0x500
>   [ 5311.783285] [<c11752b3>] ? kmem_cache_free+0x213/0x230
>   [ 5311.787677] [<c104dc73>] ? __mmdrop+0x63/0xd0
>   [ 5311.791196] [<c104dc73>] ? __mmdrop+0x63/0xd0
>   [ 5311.794712] [<c104dc73>] ? __mmdrop+0x63/0xd0
>   [ 5311.798234] [<c11a2ed7>] ? __fget+0x57/0x90
>   [ 5311.801559] [<c11a2f72>] ? __fget_light+0x22/0x50
>   [ 5311.805464] [<c119a240>] SyS_ioctl+0x80/0x90
>   [ 5311.808885] [<c1957d30>] sysenter_do_call+0x12/0x12
>   [ 5312.059280] kvm: zapping shadow pages for mmio generation wraparound
>   [ 5313.678415] kvm [4231]: vcpu0 disabled perfctr wrmsr: 0xc2 data 0xffff
>   [ 5313.726518] kvm [4231]: vcpu0 unhandled rdmsr: 0x570
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> Cc: Yang Zhang <yang.z.zhang@Intel.com>
> ---
>  arch/x86/kvm/vmx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 5eb56ed..418e084 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -4780,7 +4780,7 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)
>  
>  		vmcs_write16(GUEST_INTR_STATUS, 0);
>  
> -		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
> +		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
>  		vmcs_write64(POSTED_INTR_DESC_ADDR, __pa((&vmx->pi_desc)));
>  	}
>  
> @@ -9505,7 +9505,7 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>  		 */
>  		vmx->nested.posted_intr_nv = vmcs12->posted_intr_nv;
>  		vmx->nested.pi_pending = false;
> -		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
> +		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
>  		vmcs_write64(POSTED_INTR_DESC_ADDR,
>  			page_to_phys(vmx->nested.pi_desc_page) +
>  			(unsigned long)(vmcs12->posted_intr_desc_addr &
> 

Indeed this is a problem for 32-bit hosts.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

roy.qing.li@gmail.com Dec. 4, 2015, 12:10 a.m. UTC | #2

On Thu, Dec 3, 2015 at 9:58 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Indeed this is a problem for 32-bit hosts.


I meet this error when I run a 32bit kernel on Intel Wildcat Pass platform


-Roy
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yang Zhang Dec. 4, 2015, 1:37 a.m. UTC | #3

On 2015/12/3 13:29, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> POSTED_INTR_NV is 16bit, should not use 64bit write function
>
> [ 5311.676074] vmwrite error: reg 3 value 0 (err 12)
>    [ 5311.680001] CPU: 49 PID: 4240 Comm: qemu-system-i38 Tainted: G I 4.1.13-WR8.0.0.0_standard #1
>    [ 5311.689343] Hardware name: Intel Corporation S2600WT2/S2600WT2, BIOS SE5C610.86B.01.01.0008.021120151325 02/11/2015
>    [ 5311.699550] 00000000 00000000 e69a7e1c c1950de1 00000000 e69a7e38 fafcff45 fafebd24
>    [ 5311.706924] 00000003 00000000 0000000c b6a06dfa e69a7e40 fafcff79 e69a7eb0 fafd5f57
>    [ 5311.714296] e69a7ec0 c1080600 00000000 00000001 c0e18018 000001be 00000000 00000b43
>    [ 5311.721651] Call Trace:
>    [ 5311.722942] [<c1950de1>] dump_stack+0x4b/0x75
>    [ 5311.726467] [<fafcff45>] vmwrite_error+0x35/0x40 [kvm_intel]
>    [ 5311.731444] [<fafcff79>] vmcs_writel+0x29/0x30 [kvm_intel]
>    [ 5311.736228] [<fafd5f57>] vmx_create_vcpu+0x337/0xb90 [kvm_intel]
>    [ 5311.741600] [<c1080600>] ? dequeue_task_fair+0x2e0/0xf60
>    [ 5311.746197] [<faf3b9ca>] kvm_arch_vcpu_create+0x3a/0x70 [kvm]
>    [ 5311.751278] [<faf29e9d>] kvm_vm_ioctl+0x14d/0x640 [kvm]
>    [ 5311.755771] [<c1129d44>] ? free_pages_prepare+0x1a4/0x2d0
>    [ 5311.760455] [<c13e2842>] ? debug_smp_processor_id+0x12/0x20
>    [ 5311.765333] [<c10793be>] ? sched_move_task+0xbe/0x170
>    [ 5311.769621] [<c11752b3>] ? kmem_cache_free+0x213/0x230
>    [ 5311.774016] [<faf29d50>] ? kvm_set_memory_region+0x60/0x60 [kvm]
>    [ 5311.779379] [<c1199fa2>] do_vfs_ioctl+0x2e2/0x500
>    [ 5311.783285] [<c11752b3>] ? kmem_cache_free+0x213/0x230
>    [ 5311.787677] [<c104dc73>] ? __mmdrop+0x63/0xd0
>    [ 5311.791196] [<c104dc73>] ? __mmdrop+0x63/0xd0
>    [ 5311.794712] [<c104dc73>] ? __mmdrop+0x63/0xd0
>    [ 5311.798234] [<c11a2ed7>] ? __fget+0x57/0x90
>    [ 5311.801559] [<c11a2f72>] ? __fget_light+0x22/0x50
>    [ 5311.805464] [<c119a240>] SyS_ioctl+0x80/0x90
>    [ 5311.808885] [<c1957d30>] sysenter_do_call+0x12/0x12
>    [ 5312.059280] kvm: zapping shadow pages for mmio generation wraparound
>    [ 5313.678415] kvm [4231]: vcpu0 disabled perfctr wrmsr: 0xc2 data 0xffff
>    [ 5313.726518] kvm [4231]: vcpu0 unhandled rdmsr: 0x570
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> Cc: Yang Zhang <yang.z.zhang@Intel.com>
> ---
>   arch/x86/kvm/vmx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 5eb56ed..418e084 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -4780,7 +4780,7 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)
>
>   		vmcs_write16(GUEST_INTR_STATUS, 0);
>
> -		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
> +		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
>   		vmcs_write64(POSTED_INTR_DESC_ADDR, __pa((&vmx->pi_desc)));
>   	}
>
> @@ -9505,7 +9505,7 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>   		 */
>   		vmx->nested.posted_intr_nv = vmcs12->posted_intr_nv;
>   		vmx->nested.pi_pending = false;
> -		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
> +		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
>   		vmcs_write64(POSTED_INTR_DESC_ADDR,
>   			page_to_phys(vmx->nested.pi_desc_page) +
>   			(unsigned long)(vmcs12->posted_intr_desc_addr &
>

Yes, it is a mistake from my original patch.:(

Reviewed-by: Yang Zhang <yang.zhang.wz@gmail.com>

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 5eb56ed..418e084 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4780,7 +4780,7 @@  static int vmx_vcpu_setup(struct vcpu_vmx *vmx)
 
 		vmcs_write16(GUEST_INTR_STATUS, 0);
 
-		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
+		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
 		vmcs_write64(POSTED_INTR_DESC_ADDR, __pa((&vmx->pi_desc)));
 	}
 
@@ -9505,7 +9505,7 @@  static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
 		 */
 		vmx->nested.posted_intr_nv = vmcs12->posted_intr_nv;
 		vmx->nested.pi_pending = false;
-		vmcs_write64(POSTED_INTR_NV, POSTED_INTR_VECTOR);
+		vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
 		vmcs_write64(POSTED_INTR_DESC_ADDR,
 			page_to_phys(vmx->nested.pi_desc_page) +
 			(unsigned long)(vmcs12->posted_intr_desc_addr &

KVM: VMX: fix the writing POSTED_INTR_NV

Commit Message

Comments

Patch