From patchwork Thu Dec 3 09:30:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 7757641 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4D0B09F350 for ; Thu, 3 Dec 2015 09:30:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 79A34204D8 for ; Thu, 3 Dec 2015 09:30:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id EC40B20551 for ; Thu, 3 Dec 2015 09:30:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 514627A087; Thu, 3 Dec 2015 01:30:15 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 962BC7A087 for ; Thu, 3 Dec 2015 01:30:14 -0800 (PST) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NYR00KEBZQC1B20@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 03 Dec 2015 18:30:12 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.114]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 38.57.04949.4AB00665; Thu, 3 Dec 2015 18:30:12 +0900 (KST) X-AuditID: cbfee68d-f79646d000001355-87-56600ba4143e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 25.D7.13906.4AB00665; Thu, 3 Dec 2015 18:30:12 +0900 (KST) Received: from localhost.localdomain ([10.113.62.206]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NYR00HDVZQB3Q20@mmp1.samsung.com>; Thu, 03 Dec 2015 18:30:12 +0900 (KST) From: Inki Dae To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/3] drm/exynos: dp: fix wrong return type Date: Thu, 03 Dec 2015 18:30:09 +0900 Message-id: <1449135010-8111-3-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1449135010-8111-1-git-send-email-inki.dae@samsung.com> References: <1449135010-8111-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42JZI2JSpLuEOyHMYMZ0RYvecyeZLOYfOcdq ceXrezaL/jcLWS3OvVrJaDHp/gQWizdv1zBZvH5haNG74CqbxYzz+5gsll6/yGQxYfpaFovW vUfYHXg91sxbw+hxua+XyWPl8i9sHptWdbJ5bP/2gNXjfvdxJo8t/XfZPfq2rGL0+LxJLoAz issmJTUnsyy1SN8ugStj17Fu1oJLHBV3/r5maWDsY+9i5OSQEDCReL5qAZQtJnHh3no2EFtI YAWjxLadnDA173YdAKrhAoovZZT42LKPGaLoB6NE22VhEJtNQFVi4or7YM0iAsoSfyeuYgRp YBbYziSxYe4eRpCEsICtxK87b8CKWIAapj7/CxbnFXCWuHX2ORvENjmJk8cms4LYnAIuEqv/ /WSCWOYs8XNZK9hQCYFH7BL/F0xlhBgkIPFt8iGWLkYOoISsxKYDzBBzJCUOrrjBMoFReAEj wypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MwEg6/e9Z7w7G2wesDzEKcDAq8fAKeMaHCbEm lhVX5h5iNAXaMJFZSjQ5HxiveSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNITS1KzU1MLUovi i0pzUosPMTJxcEo1MNa9jd3Wun+lvu16Pf9t33xbBSz6s77NvXxTRWzd44LJWjo2Rxtcs4yu OdmXzFZY9uRpQpZRQo7Chlvn1T9uv7mZVVUgqIxvztWXvh3hq868LVYpYuRetD/pFVvqi43L 1AIvTGRfW/+X0fpQnPfGDIf4d98mnnfRCmJuP9WZ3NtcKGYlHmYvpMRSnJFoqMVcVJwIABmn 5GefAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t9jAd0l3AlhBruPS1v0njvJZDH/yDlW iytf37NZ9L9ZyGpx7tVKRotJ9yewWLx5u4bJ4vULQ4veBVfZLGac38dksfT6RSaLCdPXsli0 7j3C7sDrsWbeGkaPy329TB4rl39h89i0qpPNY/u3B6we97uPM3ls6b/L7tG3ZRWjx+dNcgGc UQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAhysp lCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM3Yd62YtuMRRcefva5YGxj72 LkZODgkBE4l3uw5A2WISF+6tZ+ti5OIQEljKKPGxZR8zSEJI4AejRNtlYRCbTUBVYuKK+2wg toiAssTfiasYQRqYBbYzSWyYu4cRJCEsYCvx684bsCIWoIapz/+CxXkFnCVunX3OBrFNTuLk scmsIDangIvE6n8/mSCWOUv8XNbKOIGRdwEjwypGidSC5ILipPRcw7zUcr3ixNzi0rx0veT8 3E2M4Hh9JrWD8eAu90OMAhyMSjy8Ap7xYUKsiWXFlbmHGCU4mJVEeL+tBQrxpiRWVqUW5ccX leakFh9iNAU6bCKzlGhyPjCV5JXEGxqbmBlZGpkbWhgZmyuJ89ZeigwTEkhPLEnNTk0tSC2C 6WPi4JRqYFz3u9Ghe93nHKYJiU37nj217MnfPffMee+Ly3KNBO5yXJOPVHDiY+DPSBfILgrd lTrT66TJ5usnYwUzdJ6s4Hqlo7JBMaak7rb16q+ua/Tnlfge6yo2nvjjVoFsTfeTHxVnki5G iUt5b914QnDFM+mZXK2KsVxfHvgZv5tZ9WE5T/6cYl6/YCWW4oxEQy3mouJEANv0kaXtAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, javier@osg.samsung.com, robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes wrong return type when dt binding of bridge device failed. If a board has a bridge device then of_graph_get_remote_port_parent function shouldn't be NULL. So this patch will return a proper error type so that the deferred probe isn't triggered. Changelog v2: - return -EINVAL if getting a port node failed. Signed-off-by: Inki Dae Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 60260a0..aeee60a 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -1437,8 +1437,10 @@ static int exynos_dp_probe(struct platform_device *pdev) of_node_put(bridge_node); if (!dp->ptn_bridge) return -EPROBE_DEFER; - } else - return -EPROBE_DEFER; + } else { + DRM_ERROR("no port node for bridge device.\n"); + return -EINVAL; + } } out: