From patchwork Fri Dec 4 08:45:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7766571 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4FBC6BEEE1 for ; Fri, 4 Dec 2015 08:46:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 751F72053C for ; Fri, 4 Dec 2015 08:46:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 75EC32051C for ; Fri, 4 Dec 2015 08:46:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19B638A7D6; Fri, 4 Dec 2015 00:46:36 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id A538A8A7CE for ; Fri, 4 Dec 2015 00:46:33 -0800 (PST) Received: by wmww144 with SMTP id w144so52675439wmw.1 for ; Fri, 04 Dec 2015 00:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8on/4bHJKGKrejV1zcmEe0GzAhJLCiLjP7DknujN33A=; b=Pt3aB5tz/qfaQwHiMx4LSFgvMnuzqN2UcQ/Rui+OL7/VxW7uxym2q6lvNZgJFvgDHx GlWU0Vb9iU6RDOOXCjKlO4AHO6FGxquwhHfvUXCXa9GxGGRHra5OgpjBNMo1GyrfFZzs DkM0SGSeZowYWi5WGUXl3zK5M502TTyNCPhOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8on/4bHJKGKrejV1zcmEe0GzAhJLCiLjP7DknujN33A=; b=SOdvrAyhpDy0KQfpU82Q4f8CjZIizjjbKae58FcfIR/yePwf19tuNkvS0CrsTBO/lM F7BsZ2wUHAc5OUltTIOyeJ1taRaRv/0+LdVpvmBTzgUMsB0KHj9TlSauhhgq2TWYAEk8 8oOt76OE6FA4J2z0FDsyPtGaHOsENmih1QGVBLJXkBzXsMyQHMWDjz/bOuVw8sA/lZJx d+xROtw4cVGjmVYQN+ycoOWYGCqoGkF6xPJiF3Z5xcVnyriGWaQoZdDa+fC7oacbDgZu Qgp9qCeday6E3w0qDHHPq0kmqVKl9wKdyhtLts//M13M6wp3ARqfm/XaKsXU3fFXehI1 UBMw== X-Gm-Message-State: ALoCoQlAE0vCGRDHx5X+6rQdrpdL9++DD8rQFpJ44vYBUo3a4lHd8A14fcCHTQF0fWC9c/iYBYQL X-Received: by 10.194.117.163 with SMTP id kf3mr16016520wjb.139.1449218792518; Fri, 04 Dec 2015 00:46:32 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pc2sm6926311wjb.11.2015.12.04.00.46.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Dec 2015 00:46:31 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 14/28] drm: Remove crtc/connector->save/restore hooks Date: Fri, 4 Dec 2015 09:45:55 +0100 Message-Id: <1449218769-16577-15-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP They're not how system suspend/resume should be done with atomic (there's new helpers for that developed by Thierry Redding), and for legacy drivers this really should be a helper hook and not a core one. But there's not even helper code to use them, and only 2 drivers (which now have their own private hooks) set them. Ditch them. Saves me typing some kerneldoc, too ;-) Signed-off-by: Daniel Vetter Reviewed-by: Thierry Reding --- include/drm/drm_crtc.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 340d750f1364..6c92da82f8c5 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -320,8 +320,6 @@ struct drm_crtc_state { /** * struct drm_crtc_funcs - control CRTCs for a given device - * @save: save CRTC state - * @restore: restore CRTC state * @cursor_set: setup the cursor * @cursor_set2: setup the cursor with hotspot, superseeds @cursor_set if set * @cursor_move: move the cursor @@ -339,11 +337,6 @@ struct drm_crtc_state { * bus accessors. */ struct drm_crtc_funcs { - /* Save CRTC state */ - void (*save)(struct drm_crtc *crtc); /* suspend? */ - /* Restore CRTC state */ - void (*restore)(struct drm_crtc *crtc); /* resume? */ - /** * @reset: * @@ -626,8 +619,6 @@ struct drm_connector_state { /** * struct drm_connector_funcs - control connectors on a given device * @dpms: set power state - * @save: save connector state - * @restore: restore connector state * @detect: is this connector active? * @fill_modes: fill mode list for this connector * @force: notify the driver that the connector is forced on @@ -638,8 +629,6 @@ struct drm_connector_state { */ struct drm_connector_funcs { int (*dpms)(struct drm_connector *connector, int mode); - void (*save)(struct drm_connector *connector); - void (*restore)(struct drm_connector *connector); /** * @reset: