From patchwork Fri Dec 4 16:11:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak M X-Patchwork-Id: 7767071 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 13F7CBEEE1 for ; Fri, 4 Dec 2015 10:37:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4A16C205ED for ; Fri, 4 Dec 2015 10:37:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 70203205E4 for ; Fri, 4 Dec 2015 10:37:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CFC96ED0A; Fri, 4 Dec 2015 02:37:17 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B5D1F6ED0A for ; Fri, 4 Dec 2015 02:37:15 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 04 Dec 2015 02:37:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,380,1444719600"; d="scan'208";a="700125630" Received: from mdeepakubuntudesk01-desktop.iind.intel.com ([10.223.26.119]) by orsmga003.jf.intel.com with ESMTP; 04 Dec 2015 02:37:13 -0800 From: Deepak M To: intel-gfx@lists.freedesktop.org Date: Fri, 4 Dec 2015 21:41:17 +0530 Message-Id: <1449245477-16401-1-git-send-email-m.deepak@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20151204094948.GN4437@intel.com> References: <20151204094948.GN4437@intel.com> Cc: Deepak M , Gaurav K Singh Subject: [Intel-gfx] [PATCH] drm/i915: Add DPI FIFO empty status check X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_03_06, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gaurav K Singh Before sending TURN ON packet,check the DPI FIFO empty status. v2: Change in commit message Checking for FIFO empty only during TURN ON packet. Signed-off-by: Gaurav K Singh Signed-off-by: Deepak M --- Got to know about the patch where they are removing this DPI FIFO empty check while sending the SHUTDOWN packet. http://lists.freedesktop.org/archives/intel-gfx/2014-July/048401.html According added the check and waiting for DPI FIFIO empty only when TURN_ON packet is sent. drivers/gpu/drm/i915/intel_dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 170ae6f..495056f 100644 --- a/drivers/gpu/drm/i915/intel_dsi.c +++ b/drivers/gpu/drm/i915/intel_dsi.c @@ -222,6 +222,12 @@ static int dpi_send_cmd(struct intel_dsi *intel_dsi, u32 cmd, bool hs, else cmd |= DPI_LP_MODE; + mask = DPI_FIFO_EMPTY; + + if ((cmd & TURN_ON) && wait_for((I915_READ(MIPI_GEN_FIFO_STAT(port)) & + mask) == mask, 50)) + DRM_ERROR("Timeout waiting for DPI FIFO empty\n"); + /* clear bit */ I915_WRITE(MIPI_INTR_STAT(port), SPL_PKT_SENT_INTERRUPT);