| Message ID | 1450099027-24745-4-git-send-email-m@bjorling.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Dec 14, 2015 at 02:17:05PM +0100, Matias Bj??rling wrote: > Allow read and write I/Os to be issued synchronous. Users include the > LightNVM core to implement system block support and similar. I think the right way to implement this is to wait in the caller, e.g. set your end_io handler to a trivial one that just does a complete and add a completion that you can wait on in the caller. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/15/2015 01:34 PM, Christoph Hellwig wrote: > On Mon, Dec 14, 2015 at 02:17:05PM +0100, Matias Bj??rling wrote: >> Allow read and write I/Os to be issued synchronous. Users include the >> LightNVM core to implement system block support and similar. > > I think the right way to implement this is to wait in the caller, > e.g. set your end_io handler to a trivial one that just does a complete > and add a completion that you can wait on in the caller. > Thanks Christoph. I'll change it. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index 15f2acb..1454e53 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -496,6 +496,13 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd) rq->cmd_len = sizeof(struct nvme_nvm_command); rq->special = (void *)0; + if (rqd->flags & NVM_IO_F_SYNC) { + int err = blk_execute_rq(q, NULL, rq, 0); + kfree(cmd); + blk_mq_free_request(rq); + return err; + } + rq->end_io_data = rqd; blk_execute_rq_nowait(q, NULL, rq, 0, nvme_nvm_end_io); diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h index 2fd6871..770278a 100644 --- a/include/linux/lightnvm.h +++ b/include/linux/lightnvm.h @@ -60,6 +60,9 @@ enum { NVM_BLK_T_BAD = 0x1, NVM_BLK_T_DEV = 0x2, NVM_BLK_T_HOST = 0x4, + + /* NVM Request Flags */ + NVM_IO_F_SYNC = 0x1, }; struct nvm_id_group {
Allow read and write I/Os to be issued synchronous. Users include the LightNVM core to implement system block support and similar. Signed-off-by: Matias Bjørling <m@bjorling.me> --- drivers/nvme/host/lightnvm.c | 7 +++++++ include/linux/lightnvm.h | 3 +++ 2 files changed, 10 insertions(+)